-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge to shared - TdsParserSessionPool #1595
Merge to shared - TdsParserSessionPool #1595
Conversation
…ence in the netcore project
… remove the netfx version of the file
Codecov ReportBase: 71.47% // Head: 71.44% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1595 +/- ##
==========================================
- Coverage 71.47% 71.44% -0.04%
==========================================
Files 292 290 -2
Lines 61302 61066 -236
==========================================
- Hits 43814 43626 -188
+ Misses 17488 17440 -48
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Relates to #1261. Merged netfx into netcore for TdsParserSessionPool, and moving it to shared src and updating file to conform with coding style. I left a TODO comment on line 203 because I noticed that #1520 is merging TdsParserStateObject into shared src, and once that change is in we can update this so it uses the property instead of the internal field.