Rename SimulatorEnclaveProvider - "None" attestation protocol, phase 1 #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnypham
commented
Dec 2, 2021
| clientDHKey.KeySize = 384; | ||
|
|
||
| return new SqlEnclaveAttestationParameters(2, new byte[] { }, clientDHKey); | ||
| ECDiffieHellman clientDHKey = KeyConverter.CreateECDiffieHellman(DiffieHellmanKeySize); |
There was a problem hiding this comment.
This change is required to share the file. See #1022
There was a problem hiding this comment.
Could new byte[] { } be Array.Empty<byte>() or is it not available in all supported targets?
There was a problem hiding this comment.
I think it'll work, I'll let the CI determine that 😄
Kaur-Parminder
approved these changes
Dec 3, 2021
JRahnama
reviewed
Dec 31, 2021
DavoudEshtehari
approved these changes
Dec 31, 2021
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/NoneAttestationEnclaveProvider.cs
Show resolved
Hide resolved
JRahnama
approved these changes
Jan 5, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of feature
Currently, VBS enclaves are supported on-prem and SGX enclaves on Azure VMs. VBS support for Azure is in the works but strong attestation is not possible on Azure VMs due to restrictions against accessing the host machine's Trusted Platform Module (TPM).
A new attestation protocol called "None" will be allowed in the connection string, allowing users to forgo enclave attestation when using VBS enclaves:
Attestation Protocol = None;Phase 1 changes
The existing
SimulatorEnclaveProviderperforms no attestation and only derives the shared secret required to set up a secure enclave session, which is exactly what is needed. This PR renames it to the proposedNoneAttestationEnclaveProviderand the file can now be shared across netcore and netfx.The simulator can be built with
msbuild -p:Configuration="Release" -p:BuildSimulator=true