Move to Shared - SqlSer.cs#1313
Conversation
This is part of Code merge for issue dotnet#1261. I have created .common.cs and moved the uncommon code to private methods.
|
There's not that much code remaining in the framework specific files. Why don't we just move it to the common file? |
Removed Netfx and Netcore files for SqlSer and added Netfx if endifs in common file
Just updating class not use partial anymore, indentation, comment correction
@johnnypham I just removed the netfx and netcore classes and updated SqlSer.cs in common project with the three functions.
|
DavoudEshtehari
left a comment
There was a problem hiding this comment.
The SerializationHelperSql9 could be sealed: internal sealed class SerializationHelperSql9
Also, I see some minor possible improvements like unnecessary assignment and redundant member. You can find them in the error list window.
DavoudEshtehari
left a comment
There was a problem hiding this comment.
I'd suggest using Dictionary instead of Hashtable to avoid boxing and unboxing for s_types2Serializers:
private static ConcurrentDictionary<Type, Serializer> s_types2Serializers;
addressing review comments
04593ff to
e6b777c
Compare
VSCode suggestions
Added check for key in dictionary and addressed review comments
This is part of Code merge for issue #1261. I have created .common.cs and moved the uncommon code to private methods.