Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes FormatException when Tracing is enabled #1291

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

NadeemAfana
Copy link
Contributor

This is a fix for the bug #1290 by simply removing the redundant argument from the overload.

Copy link
Contributor

@lcheunglci lcheunglci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Wraith2
Copy link
Contributor

Wraith2 commented Sep 27, 2021

Perhaps there need to be some tests run with tracing enabled.

@cheenamalhotra
Copy link
Member

The use case is related to refreshing access token before expiry which will be a long wait in test suite.
The changes look reasonable, we should prevent overriding of methods with optional params when using the generic types. The right method that should have been called in this case is on L371.

@Wraith2
Copy link
Contributor

Wraith2 commented Sep 28, 2021

Ok, making the tests take even longer isn't a good idea.

@cheenamalhotra cheenamalhotra merged commit 75fb627 into dotnet:main Sep 29, 2021
@shueybubbles
Copy link

@JRahnama can you port this fix to 3.1-servicing so we could potentially pick it up if there's another SSMS 19.x release?

@JRahnama
Copy link
Contributor

JRahnama commented Jun 2, 2023

@shueybubbles I will add this to our list.

DavoudEshtehari added a commit to DavoudEshtehari/SqlClient that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants