Move into Shared for SqlBulkCopyColumnMappingCollection.cs #1285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rc and update the references in the netfx csproj
johnnypham
suggested changes
Sep 29, 2021
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlBulkCopyColumnMappingCollection.cs
Show resolved
Hide resolved
…s://github.com/lcheunglci/SqlClient into MergeShared-SqlBulkCopyColumnMappingCollection
johnnypham
approved these changes
Sep 30, 2021
DavoudEshtehari
added
the
Code Health 💊
DavoudEshtehari
approved these changes
Oct 8, 2021
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlBulkCopyColumnMappingCollection.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1261 . I moved the netcore version of SqlBulkCopyColumnMappingCollection.cs into the shared src and updated the reference to it in the netfx csproj because they look nearly the same except that the netcore version has newer c# syntax.