Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple retry issue on ExecuteScalarAsync + add missing ConfigureAwait calls #1220

Merged
merged 2 commits into from
Aug 20, 2021
Merged

Fix multiple retry issue on ExecuteScalarAsync + add missing ConfigureAwait calls #1220

merged 2 commits into from
Aug 20, 2021

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented Aug 20, 2021 •
edited
Loading

Fixes #1219 + #1207

@DavoudEshtehari DavoudEshtehari added this to the 4.0.0-preview1 milestone Aug 20, 2021
DavoudEshtehari
DavoudEshtehari approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@DavoudEshtehari DavoudEshtehari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/RetryLogic/RetryLogicCounterTest.cs Outdated Show resolved Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/RetryLogic/RetryLogicCounterTest.cs Outdated Show resolved Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/RetryLogic/RetryLogicCounterTest.cs Outdated Show resolved Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/RetryLogic/RetryLogicCounterTest.cs Outdated Show resolved Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/RetryLogic/RetryLogicCounterTest.cs Outdated Show resolved Hide resolved
@DavoudEshtehari
Copy link
Contributor

Could you also modify the SqlRetryLogicProvider and add the ConfigureAwait(false) on async calls, please?

@cheenamalhotra cheenamalhotra linked an issue Aug 20, 2021 that may be closed by this pull request
SqlRetryLogicProvider.cs is missing ConfigureAwait(false) on it's awaits #1207
Closed
This was referenced Aug 20, 2021
Closed
Closed
@cheenamalhotra cheenamalhotra changed the title Fix multiple retry issue on ExecuteScalarAsync Fix multiple retry issue on ExecuteScalarAsync + add missing ConfigureAwait calls Aug 20, 2021
@cheenamalhotra cheenamalhotra merged commit 8412c78 into dotnet:main Aug 20, 2021
@cheenamalhotra cheenamalhotra mentioned this pull request Sep 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavoudEshtehari DavoudEshtehari DavoudEshtehari approved these changes

@Wraith2 Wraith2 Wraith2 approved these changes

@JRahnama JRahnama Awaiting requested review from JRahnama

@johnnypham johnnypham Awaiting requested review from johnnypham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0-preview1
3 participants
@cheenamalhotra @DavoudEshtehari @Wraith2