Commit 9744a8e
authored
Merge | SqlCommand (Part 1) (#3473)
* Aligning CallerMemberName arguments
* Sync TriggerInternalEndAndRetryIfNecessary signatures (as part of syncing method name parameters)
* Sync attribute formatting and some low stakes stylistic/typo stuff
* Move ExecuteReader methods to align with netcore implementation
* Remove SqlCommand from TriggerInternalEndAndRetryIfNecessary functions to align with netfx implementation
* Round one of syncing method signatures
* Align keysToBeSentToEnclave, requiresEnclaveComputations, ShouldCacheEncryptionMetadata
* Align CancelIgnoreFailureCallback and CancelIgnoreFailure
* Remove unsed CompletePendingReadWith* Methods
* Align Write*ExecuteEvent methods
* Align Clone, ICloneable.Clone and NotifyDependency
* Align BeginExecuteReader and ExecuteReader methods as per netcore implementation
* Align InternalExecuteNonQueryWithRetryAsync
* Align ExecuteReaderAsync methods
* Align ExecuteXmlReaderAsync methods
* Sync some more things, like spaces, comments
* sync _prepareHandle
* Rename CachedAsyncState to AsyncState to allow for CachedAsyncState property
Transfer all _cachedAsyncState usages to CachedAsyncState
This could be dangerous since property behavior is slightly different than the direct member variable.
* sync isRetry and isAsync variable names
* Sync { // lines
* Sync event/trace/correlation messages
* Revert "Remove SqlCommand from TriggerInternalEndAndRetryIfNecessary functions to align with netfx implementation"
This reverts commit 6fccc8f.
Align netfx implementation with netcore implementation1 parent 387bb4d commit 9744a8e
File tree
2 files changed
+1245
-1058
lines changed- src/Microsoft.Data.SqlClient
- netcore/src/Microsoft/Data/SqlClient
- netfx/src/Microsoft/Data/SqlClient
2 files changed
+1245
-1058
lines changed
0 commit comments