Merge branch 'main' into merge-tdsparser-typealiases

Author: MichelZ

BUILDGUIDE.md

@@ -11,7 +11,7 @@ Microsoft.Data.SqlClient is a .NET data provider for [Microsoft SQL Server]([url
 The Microsoft.Data.SqlClient package supports the following environments:
 
 - .NET Framework 4.6.2+
-- .NET 6.0+
+- .NET 8.0
 
 ## Download
 

README.md

@@ -28,7 +28,6 @@ call :pauseOnError msbuild -t:Clean
 
 echo Building .NET Framework %netfxVersion% Tests ...
 call :pauseOnError msbuild -p:Configuration="Release"
-call :pauseOnError msbuild -p:Configuration="Release" -t:BuildAKVNetStAllOS
 call :pauseOnError msbuild -p:Configuration="Release" -t:BuildAKVNetFx
 call :pauseOnError msbuild -p:Configuration="Release" -t:BuildTestsNetFx -p:TargetNetFxVersion=%netfxVersion%
 
@@ -40,7 +39,6 @@ echo Building .NET %netcoreVersion% Tests ...
 call pause
 call :pauseOnError msbuild -t:Clean
 call :pauseOnError msbuild -p:Configuration="Release"
-call :pauseOnError msbuild -p:Configuration="Release" -t:BuildAKVNetStAllOS
 call :pauseOnError msbuild -p:Configuration="Release" -t:BuildAKVNetCoreAllOS
 call :pauseOnError msbuild -p:Configuration="Release" -t:BuildTestsNetCore -p:TargetNetCoreVersion=%netcoreVersion%
 

RunProjectReferenceTests.cmd

@@ -2,7 +2,6 @@ call :pauseOnError msbuild -p:configuration=Release -t:clean
 call :pauseOnError msbuild -p:configuration=Release -t:BuildAllConfigurations
 call :pauseOnError msbuild -p:configuration=Release -t:BuildAKVNetFx
 call :pauseOnError msbuild -p:configuration=Release -t:BuildAKVNetCoreAllOS
-call :pauseOnError msbuild -p:configuration=Release -t:BuildAKVNetStAllOS
 call :pauseOnError msbuild -p:configuration=Release -t:GenerateAKVProviderNugetPackage
 
 goto :eof

buildAddons.cmd

@@ -33,8 +33,6 @@ We use and recommend the following workflow:
 
 ## PR - CI Process
 
-_[Coming Soon - Currently under development]_
-
 The [SqlClient Continuous Integration](https://dev.azure.com/sqlclientdrivers-ci/sqlclient/) (CI) system will automatically perform the required builds and run tests (including the ones you are expected to run) for PRs. Builds and test runs must be clean.
 
 If the CI build fails for any reason, the PR issue will be updated with a link that can be used to determine the cause of the failure.

contributing-workflow.md

@@ -384,7 +384,7 @@ stages:
           pool: $(defaultHostedPoolName)
           hostedPool: true
           images:
-            MacOS12_Azure_Sql: macOS-12
+            MacOSLatest_Azure_Sql: macos-latest
           TargetFrameworks: ${{parameters.targetFrameworksLinux }}
           netcoreVersionTestUtils: ${{parameters.netcoreVersionTestUtils }}
           buildPlatforms: [AnyCPU]

doc/snippets/Microsoft.Data.SqlClient/SQLDebugging.xml

@@ -37,7 +37,7 @@ For .NET Framework projects it may be necessary to include the following in your
         <DbProviderFactories>
             <add name="SqlClient Data Provider"
                 invariant="Microsoft.Data.SqlClient"
-                description=".Net Framework Data Provider for SqlServer" 
+                description=".Net Framework Data Provider for SqlServer"
                 type="Microsoft.Data.SqlClient.SqlClientFactory, Microsoft.Data.SqlClient" />
         </DbProviderFactories>
     </system.data>
@@ -52,6 +52,7 @@ For .NET Framework projects it may be necessary to include the following in your
 | Can use DateTime object as value for SqlParameter with type `DbType.Time`. | Must use TimeSpan object as value for SqlParameter with type `DbType.Time`. |
 | Using DateTime object as value for SqlParameter with type `DbType.Date` would send date and time to SQL Server. | DateTime object's time components will be truncated when sent to SQL Server using `DbType.Date`. |
 | `Encrypt` defaults to `false`. | Starting in v4.0, default encryption settings were made more secure, requiring opt-in to non-encrypted connections. `Encrypt` defaults to `true` and the driver will always validate the server certificate based on `TrustServerCertificate`. (Previously, server certificates would only be validated if `Encrypt` was also `true`.)<br/><br/>If you need to turn off encryption, you must specify `Encrypt=false`. If you use encryption with a self-signed certificate on the server, you must specify `TrustServerCertificate=true`.<br/><br/>In v5.0, `SqlConnectionStringBuilder.Encrypt` is no longer a `bool`. It's a `SqlConnectionEncryptOption` with multiple values to support `Strict` encryption mode (TDS 8.0). It uses implicit conversion operators to remain code-backwards compatible, but it was a binary breaking change, requiring a recompile of applications. |
+| ConnectionString property uses non-backward compatible keywords with spaces. | The `SqlConnectionStringBuilder` has a `ConnectionString` property that can be used to get the connection string to connect with. The [`Microsoft.Data.SqlClient` connection string](https://learn.microsoft.com/en-us/dotnet/api/microsoft.data.sqlclient.sqlconnection.connectionstring) and the [`System.Data.SqlClient` connection string](https://learn.microsoft.com/en-us/dotnet/api/system.data.sqlclient.sqlconnection.connectionstring) do not support all of the same keywords, so be mindful of that. The `Microsoft.Data.SqlClient` also adds new aliases for some existing keywords. For example, `Microsoft.Data.SqlClient` now supports `Application Intent=ReadOnly` and `Multi Subnet Failover=True`, in addition to the previous `ApplicationIntent=ReadOnly` and `MultiSubnetFailover=True` (notice the spaces in the keywords). Unfortunately, the `SqlConnectionStringBuilder.ConnectionString` uses the new aliases with spaces, which do not exist and are unsupported in `System.Data.SqlClient`. This means if you build a connection string with `Microsoft.Data.SqlClient`, but attempt to use it in an application using `System.Data.SqlClient`, the connection string will not be valid for `System.Data.SqlClient`; you will need to sanitize the connection string by removing the spaces from the keywords. |
 
 ## .NET Framework to .NET Considerations
 

eng/pipelines/dotnet-sqlclient-ci-core.yml

@@ -128,7 +128,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Microsoft.Data.SqlClient",
 		..\doc\snippets\Microsoft.Data.SqlClient\SqlCredential.xml = ..\doc\snippets\Microsoft.Data.SqlClient\SqlCredential.xml
 		..\doc\snippets\Microsoft.Data.SqlClient\SqlDataAdapter.xml = ..\doc\snippets\Microsoft.Data.SqlClient\SqlDataAdapter.xml
 		..\doc\snippets\Microsoft.Data.SqlClient\SqlDataReader.xml = ..\doc\snippets\Microsoft.Data.SqlClient\SqlDataReader.xml
-		..\doc\snippets\Microsoft.Data.SqlClient\SQLDebugging.xml = ..\doc\snippets\Microsoft.Data.SqlClient\SQLDebugging.xml
 		..\doc\snippets\Microsoft.Data.SqlClient\SqlDependency.xml = ..\doc\snippets\Microsoft.Data.SqlClient\SqlDependency.xml
 		..\doc\snippets\Microsoft.Data.SqlClient\SqlEnclaveAttestationParameters.xml = ..\doc\snippets\Microsoft.Data.SqlClient\SqlEnclaveAttestationParameters.xml
 		..\doc\snippets\Microsoft.Data.SqlClient\SqlEnclaveSession.xml = ..\doc\snippets\Microsoft.Data.SqlClient\SqlEnclaveSession.xml

porting-cheat-sheet.md

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#if NET && !NET8_0_OR_GREATER
+
 namespace System.Net
 {
     [Serializable]
@@ -21,3 +23,5 @@ public InternalException(string message, Exception innerException) : base(messag
         }
     }
 }
+
+#endif