Remove AreConnStringsNotAzureSynapse

Adding doc comments to DisposableArray

Author: benrr101

src/Microsoft.Data.SqlClient/tests/Common/DisposableArray.cs

@@ -6,31 +6,62 @@
 using System.Collections;
 using System.Collections.Generic;
 
+#nullable enable
+
 namespace Microsoft.Data.SqlClient.Tests.Common
 {
+    /// <summary>
+    /// Utility class that enables disposal of a collection of <see cref="IDisposable"/> objects
+    /// with a single <c>using</c> statement.
+    /// </summary>
+    /// <typeparam name="T">Type of the elements contained within.</typeparam>
     public class DisposableArray<T> : IDisposable, IEnumerable<T>
-        where T : IDisposable
+        where T : IDisposable?
     {
         private readonly T[] _elements;
 
-        public T this[int i]
-        {
-            get => _elements[i];
-            set => _elements[i] = value;
-        }
-
-        public int Length => _elements.Length;
-
+        /// <summary>
+        /// Constructs a new instance with <paramref name="size"/> elements.
+        /// </summary>
+        /// <remarks>
+        /// Remember when using this constructor that the underlying array will be initialized to
+        /// <c>default(T)</c>. If <typeparamref name="T"/> is a reference type, this will be
+        /// <c>null</c> - even if <typeparamref name="T"/> is not nullable!
+        /// </remarks>
+        /// <param name="size">Number of elements the new instance will contain.</param>
         public DisposableArray(int size)
         {
             _elements = new T[size];
         }
 
+        /// <summary>
+        /// Constructs a new instance from an existing array of elements.
+        /// </summary>
+        /// <param name="elements">Array of elements to store within the current instance.</param>
         public DisposableArray(T[] elements)
         {
             _elements = elements;
         }
 
+        /// <summary>
+        /// Gets or sets the element at index <see cref="i"/>.
+        /// </summary>
+        /// <param name="i">The element to get/set will be at this position in the array</param>
+        public T this[int i]
+        {
+            get => _elements[i];
+            set => _elements[i] = value;
+        }
+
+        /// <summary>
+        /// Gets the number of elements in the array.
+        /// </summary>
+        public int Length => _elements.Length;
+
+        /// <summary>
+        /// Disposes all elements in the current instance. Each element will be checked for
+        /// <c>null</c> before disposing it.
+        /// </summary>
         public void Dispose()
         {
             foreach (T element in _elements)
@@ -41,9 +72,11 @@ public void Dispose()
             GC.SuppressFinalize(this);
         }
 
+        /// <inheritdoc/>
         public IEnumerator<T> GetEnumerator() =>
             ((IEnumerable<T>)_elements).GetEnumerator();
 
+        /// <inheritdoc/>
         IEnumerator IEnumerable.GetEnumerator() =>
             _elements.GetEnumerator();
     }

src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs

@@ -409,9 +409,6 @@ public static bool AreConnStringsSetup()
             return !string.IsNullOrEmpty(NPConnectionString) && !string.IsNullOrEmpty(TCPConnectionString);
         }
 
-        public static bool AreConnStringsNotAzureSynapse() =>
-            AreConnStringsSetup() && IsNotAzureSynapse();
-
         public static bool IsSQL2022() => string.Equals("16", SQLServerVersion.Trim());
 
         public static bool IsSQL2019() => string.Equals("15", SQLServerVersion.Trim());

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/MARSSessionPoolingTest/MarsSessionPoolingTest.cs

@@ -368,7 +368,7 @@ private static void AssertSessionsAndRequests(
 
         private static DisposableArray<SqlCommand> GetCommands(SqlConnection connection, CommandType commandType)
         {
-            SqlCommand[] result = new SqlCommand[ConcurrentCommands];
+            DisposableArray<SqlCommand> result = new(ConcurrentCommands);
             for (int i = 0; i < result.Length; i++)
             {
                 switch (commandType)
@@ -401,7 +401,7 @@ private static DisposableArray<SqlCommand> GetCommands(SqlConnection connection,
                 }
             }
 
-            return new DisposableArray<SqlCommand>(result);
+            return result;
         }
 
         private static SqlConnection GetConnection()