Add Legacy OpenGL ImGuiController #854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should run on as low as OpenGL2.0
Perksey
approved these changes
Mar 20, 2022
There was a problem hiding this comment.
Model PR, thank you so much!
@ThomasMiz area owner signoff?
Perksey
approved these changes
Mar 20, 2022
src/OpenGL/Extensions/Silk.NET.OpenGL.Extensions.ImGui/ImGuiController.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Dylan Perks <11160611+Perksey@users.noreply.github.com>
|
@Perksey We're getting the workload install problems on the CI again, should we merge anyways? |
|
Yep sounds fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Adds an OpenGL2.0 compatible ImGuiRenderer
Additional Info
I removed glVersion as it was never used and caused issues on older GL versions