Skip to content

Commit 3e90481

Browse files
authored
Improved Test Naming (#939)
1 parent 0805e76 commit 3e90481

File tree

9 files changed

+29
-16
lines changed

9 files changed

+29
-16
lines changed

tests/Silk.NET.SilkTouch.Emitter.Tests/EmitterFieldTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public void FieldIsPublic()
3939
}
4040

4141
[Fact]
42-
public void FieldHasCorrectTypeIdentifier()
42+
public void CorrectTypeIdentifier()
4343
{
4444
var syntax = Transform
4545
(
@@ -57,7 +57,7 @@ public void FieldHasCorrectTypeIdentifier()
5757
}
5858

5959
[Fact]
60-
public void FieldHasCorrectIdentifier()
60+
public void CorrectIdentifier()
6161
{
6262
var syntax = Transform
6363
(

tests/Silk.NET.SilkTouch.Emitter.Tests/EmitterNamespaceMemberTests.cs

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ namespace Silk.NET.SilkTouch.Emitter.Tests;
1111
public class EmitterNamespaceMemberTests : EmitterTest
1212
{
1313
[Fact]
14-
public void NamespaceIntegration()
14+
public void SingleMemberIntegration()
1515
{
1616
var syntax = Transform(new NamespaceSymbol(new IdentifierSymbol("Test"), (new []
1717
{
@@ -21,4 +21,17 @@ public void NamespaceIntegration()
2121
var result = syntax.ToFullString();
2222
Assert.Equal("namespace Test\n{\n[StructLayout(LayoutKind.Explicit)]\npublic struct Test2\n{\n}\n}\n", result);
2323
}
24+
25+
[Fact]
26+
public void MultipleMembersIntegration()
27+
{
28+
var syntax = Transform(new NamespaceSymbol(new IdentifierSymbol("Test"), (new []
29+
{
30+
(TypeSymbol)new StructSymbol(new IdentifierSymbol("Test2"), StructLayout.Empty),
31+
(TypeSymbol)new StructSymbol(new IdentifierSymbol("Test3"), StructLayout.Empty)
32+
}).ToImmutableArray()));
33+
34+
var result = syntax.ToFullString();
35+
Assert.Equal("namespace Test\n{\n[StructLayout(LayoutKind.Explicit)]\npublic struct Test2\n{\n}\n[StructLayout(LayoutKind.Explicit)]\npublic struct Test3\n{\n}\n}\n", result);
36+
}
2437
}

tests/Silk.NET.SilkTouch.Emitter.Tests/EmitterNamespaceTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public void NamespaceIntegration()
2222
}
2323

2424
[Fact]
25-
public void NamespaceHasCorrectIdentifier()
25+
public void CorrectIdentifier()
2626
{
2727
var syntax = Transform
2828
(new NamespaceSymbol(new IdentifierSymbol("Test"), ImmutableArray<TypeSymbol>.Empty)) as

tests/Silk.NET.SilkTouch.Emitter.Tests/EmitterStructMemberFieldsTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ namespace Silk.NET.SilkTouch.Emitter.Tests;
1010
public class EmitterStructMemberFieldsTests : EmitterTest
1111
{
1212
[Fact]
13-
public void StructWithSingleFieldIntegration()
13+
public void SingleFieldIntegration()
1414
{
1515
var node = Transform
1616
(
@@ -40,7 +40,7 @@ public struct Test
4040
}
4141

4242
[Fact]
43-
public void StructWithMultipleFieldsIntegration()
43+
public void MultipleFieldsIntegration()
4444
{
4545
var node = Transform
4646
(

tests/Silk.NET.SilkTouch.Emitter.Tests/EmitterStructTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,28 +11,28 @@ namespace Silk.NET.SilkTouch.Emitter.Tests;
1111
public sealed class EmitterStructTests : EmitterTest
1212
{
1313
[Fact]
14-
public void StructIsStructSyntax()
14+
public void StructSyntax()
1515
{
1616
var syntax = Transform(new StructSymbol(new IdentifierSymbol("Test"), StructLayout.Empty));
1717
Assert.IsType<StructDeclarationSyntax>(syntax);
1818
}
1919

2020
[Fact]
21-
public void StructHasStructKeyword()
21+
public void StructKeyword()
2222
{
2323
var syntax = Transform(new StructSymbol(new IdentifierSymbol("Test"), StructLayout.Empty)) as StructDeclarationSyntax;
2424
Assert.Equal("struct", syntax!.Keyword.Text);
2525
}
2626

2727
[Fact]
28-
public void StructHasCorrectIdentifier()
28+
public void CorrectIdentifier()
2929
{
3030
var syntax = Transform(new StructSymbol(new IdentifierSymbol("Test"), StructLayout.Empty)) as StructDeclarationSyntax;
3131
Assert.Equal("Test", syntax!.Identifier.Text);
3232
}
3333

3434
[Fact]
35-
public void StructIsOnlyPublic()
35+
public void IsOnlyPublic()
3636
{
3737
var syntax = Transform(new StructSymbol(new IdentifierSymbol("Test"), StructLayout.Empty)) as StructDeclarationSyntax;
3838
var @public = Assert.Single(syntax!.Modifiers);

tests/Silk.NET.SilkTouch.IntegrationTests/StructIntegrationTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public class StructIntegrationTests
1313
[Fact]
1414
public Task Test1()
1515
{
16-
var result = TestHelper.GetCSharpOutputFromCPP(@"
16+
var result = TestHelper.GetCSharpOutputFromCpp(@"
1717
#include <stdint.h>
1818
1919
typedef struct {

tests/Silk.NET.SilkTouch.IntegrationTests/TestHelper.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ namespace Silk.NET.SilkTouch.IntegrationTests;
1313

1414
public static class TestHelper
1515
{
16-
public static string GetCSharpOutputFromCPP(string cpp)
16+
public static string GetCSharpOutputFromCpp(string cpp)
1717
{
1818
var tempFile = Path.GetTempFileName();
1919

tests/Silk.NET.SilkTouch.Scraper.Tests/IdentityScrapingTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ namespace Silk.NET.SilkTouch.Scraper.Tests;
1010
public class IdentityScrapingTests
1111
{
1212
[Fact]
13-
public void EmptyXmlGeneratesNoSymbols()
13+
public void GeneratesNoSymbols()
1414
{
1515
var doc = new XmlDocument();
1616

@@ -20,7 +20,7 @@ public void EmptyXmlGeneratesNoSymbols()
2020
}
2121

2222
[Fact]
23-
public void EmptyBindingsXmlGeneratesNoSymbols()
23+
public void BindingsGeneratesNoSymbols()
2424
{
2525
var doc = new XmlDocument();
2626
doc.LoadXml(@"<bindings>

tests/Silk.NET.SilkTouch.Scraper.Tests/StructScrapingTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ namespace Silk.NET.SilkTouch.Scraper.Tests;
1010
public class StructScrapingTests
1111
{
1212
[Fact]
13-
public void StructXMLGeneratesStructSymbol()
13+
public void StructSymbol()
1414
{
1515
var doc = new XmlDocument();
1616
doc.LoadXml(@"<struct name=""Test""></struct>");
@@ -22,7 +22,7 @@ public void StructXMLGeneratesStructSymbol()
2222
}
2323

2424
[Fact]
25-
public void StructXMLGeneratesCorrectIdentifier()
25+
public void CorrectIdentifier()
2626
{
2727
var doc = new XmlDocument();
2828
doc.LoadXml(@"<struct name=""Test""></struct>");

0 commit comments

Comments
 (0)