[2.0] Fix the experimental feed (#356)

* Add some log messages to find out what's going on

* Fix build

* Adjust the pipeline

* Zero what? Elephants?

* Update build.yml

* Ok seriously what is going on

* Maybe it's a path thing?

* Ohhhhh

* Comment out the cwd artifact for now, will clean later

* Commit finished NUKE build system

* Commit finished build pipeline

* There was a reason pack and push were separate

Author: Perksey

.github/workflows/build.yml

@@ -21,11 +21,13 @@ jobs:
         dotnet-version: 5.0.100
     - name: Setup NUKE
       run: dotnet tool install Nuke.GlobalTool --global
-    - name: Pack
-      # TODO build native mixins such as BuildLibSilkDroid
-      run: nuke Pack --configuration Release --msbuild-properties VersionSuffix=build$GITHUB_RUN_NUMBER.0 ContinuousIntegrationBuild=true --feature-sets Android iOS
     - name: Test
+      # skip Clean, Restore, and Compile as this will build the affect the whole solution.
+      # dotnet test will compile the necessary projects for testing only.
       run: nuke Test --skip Clean Restore Compile
+    - name: Pack
+      # TODO build native mixins such as BuildLibSilkDroid
+      run: nuke Pack --configuration Release --msbuild-properties VersionSuffix=build${{ github.run_number }}.0 ContinuousIntegrationBuild=true --feature-sets Android iOS
     - name: Push to NuGet
       if: ${{ github.repository == 'Ultz/Silk.NET' && github.event_name != 'pull_request' }}
-      run: nuke PushToNuGet --skip Clean Restore Pack --nuget-feed https://pkgs.dev.azure.com/UltzOS/Silk.NET/_packaging/Experimental/nuget/v3/index.json --nuget-username ${{ secrets.AZDO_ARTIFACTS_USERNAME }} --nuget-password ${{ secrets.AZDO_ARTIFACTS_TOKEN }} --nuget-api-key az
+      run: nuke PushToNuGet --skip Clean Restore Compile Pack --nuget-feed https://pkgs.dev.azure.com/UltzOS/Silk.NET/_packaging/Experimental/nuget/v3/index.json --nuget-username ${{ secrets.AZDO_ARTIFACTS_USERNAME }} --nuget-password ${{ secrets.AZDO_ARTIFACTS_TOKEN }} --nuget-api-key az

build/nuke/Build.cs

@@ -373,15 +373,18 @@ async Task PushPackages()
     {
         const int rateLimit = 300;
         var allFiles = Directory.GetFiles(RootDirectory / "build" / "output_packages", "*.nupkg")
-            .Where(x => x.StartsWith("Silk.NET"))
+            .Where(x => Path.GetFileName(x).StartsWith("Silk.NET"))
             .Select((x, i) => new {Index = i, Value = x})
             .GroupBy(x => x.Index / rateLimit)
             .Select(x => x.Select(v => v.Value).ToList())
             .ToList();
         var first = true;
+        var pushed = 0;
         var feed = NuGetInterface.OpenNuGetFeed(NugetFeed, NugetUsername, NugetPassword);
         var uploadResource = await NuGetInterface.GetUploadResourceAsync(feed);
         var symbolsResource = await NuGetInterface.GetSymbolsUploadResourceAsync(feed);
+        var exceptions = new List<Exception>();
+        Logger.Info($"Searching for packages in \"{RootDirectory / "build" / "output_packages"}\"...");
         foreach (var files in allFiles)
         {
             if (first)
@@ -393,24 +396,25 @@ async Task PushPackages()
                 await Task.Delay(TimeSpan.FromHours(1));
             }
 
-            var exceptions = new List<Exception>();
-
             foreach (var file in files)
             {
                 try
                 {
                     await NuGetInterface.UploadPackageAsync(uploadResource, NugetNoServiceEndpoint, file, NugetApiKey, symbolsResource);
+                    pushed++;
                 }
                 catch (Exception ex)
                 {
                     exceptions.Add(new Exception($"Failed to push package \"{file}\"", ex));
                 }
             }
+        }
 
-            if (exceptions.Count > 0)
-            {
-                throw new AggregateException(exceptions);
-            }
+        Logger.Success($"Successfully pushed {pushed} packages.");
+
+        if (exceptions.Count > 0)
+        {
+            throw new AggregateException(exceptions);
         }
     }
 }

src/OpenGL/Silk.NET.OpenGL/GL.cs

@@ -375,7 +375,7 @@ public string GetActiveAttrib(uint program, uint index, out int size, out Attrib
             length = (uint) lengthTmp;
 
             GetActiveAttrib
-                (program, index, (uint) (length == 0 ? 1 : length * 2), out length, out size, out type, out var str);
+                (program, index, (uint) (length == 0 ? 1 : length * 2), out length, out size, out type, out string str);
 
             return str.Substring(0, (int) length);
         }
@@ -408,7 +408,7 @@ public string GetActiveUniform(uint program, uint uniformIndex, out int size, ou
             length = (uint) lengthTmp;
 
             GetActiveUniform
-                (program, uniformIndex, length == 0 ? 1 : length, out length, out size, out type, out var str);
+                (program, uniformIndex, length == 0 ? 1 : length, out length, out size, out type, out string str);
 
             return str.Substring(0, (int) length);
         }