Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting started app #3079

Merged
merged 5 commits into from
Feb 22, 2021
Merged

Fix getting started app #3079

merged 5 commits into from
Feb 22, 2021

Conversation

roji
Copy link
Member

@roji roji commented Feb 4, 2021

Fixes #3078

Create the database with EnsureCreated instead of with Migrations.

Fixes #3078
Copy link
Member

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on issue.

@@ -9,7 +9,7 @@ public class BloggingContext : DbContext
public DbSet<Post> Posts { get; set; }

protected override void OnConfiguring(DbContextOptionsBuilder options)
=> options.UseSqlite("Data Source=blogging.db");
=> options.UseSqlite(@"Data Source=C:\blogging.db");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VS Mac tab is available but probably not what you want. Need either code comments or note before code for mac/linix

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this note look?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can also add a comment here in code what to use if your are using mac/linux.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it turns out even folks reading localized content prefer helpful english code comments. I hate the chrome of a note. I'd move this to the code comments and remove the note. Note chrome detracts from the flow of the article.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to note into a code comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting started example does not work
4 participants