Use colons consistently for connection strings in UserSecrets #3008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2805 Fixes #2995 I think I figured out the continual confusion here. The colon is always correct when reading from ASP.NET config JSON. However, when using UserSecrets, the secret can be stored as either `ConnectionString.Foo` or `ConnectionString:Foo`. We showed examples using periods, which then works when looking up with periods. But then this doesn't work for connection strings from configuration, even though the document makes the assumption that these things work the same. The fix here is to use colons consistently. I also plan to update more of the connection strings documentation at a later time. But many people have hit this, so wanted to fix it now.
roji
approved these changes
Jan 12, 2021
bricelam
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2805
Fixes #2995
I think I figured out the continual confusion here. The colon is always correct when reading from ASP.NET config JSON. However, when using UserSecrets, the secret can be stored as either
ConnectionString.FooorConnectionString:Foo. We showed examples using periods, which then works when looking up with periods. But then this doesn't work for connection strings from configuration, even though the document makes the assumption that these things work the same.The fix here is to use colons consistently. I also plan to update more of the connection strings documentation at a later time. But many people have hit this, so wanted to fix it now.