Skip to content

Support AOT #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Egbert-Jan
Copy link

No description provided.

@Egbert-Jan
Copy link
Author

@dotnet-policy-service agree

@HofmeisterAn
Copy link
Contributor

Hi 👋, just a quick heads-up: This repo is pretty inactive. We've forked it and are taking care of maintenance, bug fixes, and new features. If you'd like to make this PR compatible with our forked version, I'd be happy to review and merge it.

Here are a few things I noticed after a quick look:

  • Doesn't it require project-level AOT configuration?
  • Ideally, we should generate the DockerDotnetJsonSerializerContext.Generated.cs file using the Go implementation that already generates the model classes.
  • Some things were removed, and I'm not sure why, but we can discuss that in a PR on the forked version.

Thanks for contributing, really appreciate the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants