Skip to content

Commit de8ba07

Browse files
filzrevfilzrev
authored
chore: suppress xunit non-serializable data warnings (#2769)
1 parent a08f01c commit de8ba07

File tree

7 files changed

+51
-51
lines changed

7 files changed

+51
-51
lines changed

‎tests/BenchmarkDotNet.IntegrationTests/ArgumentsTests.cs

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public static IEnumerable<object[]> GetToolchains()
2424

2525
public ArgumentsTests(ITestOutputHelper output) : base(output) { }
2626

27-
[Theory, MemberData(nameof(GetToolchains))]
27+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
2828
public void ArgumentsArePassedToBenchmarks(IToolchain toolchain) => CanExecute<WithArguments>(toolchain);
2929

3030
public class WithArguments
@@ -61,7 +61,7 @@ public ValueTask<int> SimpleValueTaskAsync(bool boolean, int number)
6161
}
6262
}
6363

64-
[Theory, MemberData(nameof(GetToolchains))]
64+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
6565
public void ArgumentsFromSourceArePassedToBenchmarks(IToolchain toolchain) => CanExecute<WithArgumentsSource>(toolchain);
6666

6767
public class WithArgumentsSource
@@ -81,7 +81,7 @@ public IEnumerable<object[]> ArgumentsProvider()
8181
}
8282
}
8383

84-
[Theory, MemberData(nameof(GetToolchains))]
84+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
8585
public void ArgumentsFromSourceInAnotherClassArePassedToBenchmarks(IToolchain toolchain) => CanExecute<WithArgumentsSourceInAnotherClass>(toolchain);
8686

8787
public class WithArgumentsSourceInAnotherClass
@@ -103,7 +103,7 @@ public static IEnumerable<object[]> ArgumentsProvider()
103103
}
104104
}
105105

106-
[Theory, MemberData(nameof(GetToolchains))]
106+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
107107
public void ArgumentsCanBePassedByReferenceToBenchmark(IToolchain toolchain) => CanExecute<WithRefArguments>(toolchain);
108108

109109
public class WithRefArguments
@@ -118,7 +118,7 @@ public void Simple(ref bool boolean, ref int number)
118118
}
119119
}
120120

121-
[Theory, MemberData(nameof(GetToolchains))]
121+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
122122
public void ArgumentsCanBePassedByReadonlyReferenceToBenchmark(IToolchain toolchain) => CanExecute<WithInArguments>(toolchain);
123123

124124
public class WithInArguments
@@ -133,7 +133,7 @@ public void Simple(in bool boolean, in int number)
133133
}
134134
}
135135

136-
[Theory, MemberData(nameof(GetToolchains))]
136+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
137137
public void NonCompileTimeConstantsCanBeReturnedFromSource(IToolchain toolchain) => CanExecute<WithComplexTypesReturnedFromSources>(toolchain);
138138

139139
public class WithComplexTypesReturnedFromSources
@@ -190,7 +190,7 @@ public struct SomeStruct
190190
}
191191
}
192192

193-
[Theory, MemberData(nameof(GetToolchains))]
193+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
194194
public void ArrayCanBeUsedAsArgument(IToolchain toolchain) => CanExecute<WithArray>(toolchain);
195195

196196
public class WithArray
@@ -208,7 +208,7 @@ public void AcceptingArray(int[] array)
208208
}
209209
}
210210

211-
[Theory, MemberData(nameof(GetToolchains))]
211+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
212212
public void IEnumerableCanBeUsedAsArgument(IToolchain toolchain) => CanExecute<WithIEnumerable>(toolchain);
213213

214214
public class WithIEnumerable
@@ -233,7 +233,7 @@ public IEnumerable<object[]> Sources()
233233
public void Any(string name, IEnumerable<int> source) => source.Any();
234234
}
235235

236-
[Theory, MemberData(nameof(GetToolchains))]
236+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
237237
public void JaggedArrayCanBeUsedAsArgument(IToolchain toolchain) => CanExecute<WithJaggedArray>(toolchain);
238238

239239
public class WithJaggedArray
@@ -269,7 +269,7 @@ public IEnumerable<object> CreateMatrix()
269269
}
270270
}
271271

272-
[Theory, MemberData(nameof(GetToolchains))]
272+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
273273
public void GenericTypeCanBePassedByRefAsArgument(IToolchain toolchain) => CanExecute<WithGenericByRef>(toolchain);
274274

275275
public class WithGenericByRef
@@ -305,7 +305,7 @@ public IEnumerable<object> GetInputData()
305305
}
306306
}
307307

308-
[Theory, MemberData(nameof(GetToolchains))]
308+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
309309
public void AnArrayOfTypeWithNoParameterlessCtorCanBePassedAsArgument(IToolchain toolchain) => CanExecute<WithArrayOfStringAsArgument>(toolchain);
310310

311311
public class WithArrayOfStringAsArgument
@@ -322,7 +322,7 @@ public void TypeReflectionArrayGetType(object anArray)
322322
}
323323
}
324324

325-
[Theory, MemberData(nameof(GetToolchains))]
325+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
326326
public void AnArrayCanBePassedToBenchmarkAsSpan(IToolchain toolchain) => CanExecute<WithArrayToSpan>(toolchain);
327327

328328
public class WithArrayToSpan
@@ -342,7 +342,7 @@ public void AcceptsSpan(Span<int> span)
342342

343343
[TheoryEnvSpecific("The implicit cast operator is available only in .NET Core 2.1+ (See https://github.com/dotnet/corefx/issues/30121 for more)",
344344
EnvRequirement.DotNetCoreOnly)]
345-
[MemberData(nameof(GetToolchains))]
345+
[MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
346346
public void StringCanBePassedToBenchmarkAsReadOnlySpan(IToolchain toolchain) => CanExecute<WithStringToReadOnlySpan>(toolchain);
347347

348348
public class WithStringToReadOnlySpan
@@ -360,7 +360,7 @@ public void AcceptsReadOnlySpan(ReadOnlySpan<char> notString)
360360
}
361361
}
362362

363-
[Theory, MemberData(nameof(GetToolchains))]
363+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
364364
public void AnArrayOfStringsCanBeUsedAsArgument(IToolchain toolchain) =>
365365
CanExecute<WithArrayOfStringFromArgumentSource>(toolchain);
366366

@@ -380,7 +380,7 @@ public void TypeReflectionArrayGetType(string[] array)
380380
}
381381
}
382382

383-
[Theory, MemberData(nameof(GetToolchains))] // make sure BDN mimics xunit's MemberData behaviour
383+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)] // make sure BDN mimics xunit's MemberData behaviour
384384
public void AnIEnumerableOfArrayOfObjectsCanBeUsedAsArgumentForBenchmarkAcceptingSingleArgument(IToolchain toolchain)
385385
=> CanExecute<WithIEnumerableOfArrayOfObjectsFromArgumentSource>(toolchain);
386386

@@ -400,7 +400,7 @@ public void SingleArgument(bool boolean)
400400
}
401401
}
402402

403-
[Theory, MemberData(nameof(GetToolchains))]
403+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
404404
public void BenchmarkCanAcceptFewArrays(IToolchain toolchain) => CanExecute<FewArrays>(toolchain);
405405

406406
public class FewArrays
@@ -429,7 +429,7 @@ public void AcceptsArrays(int[] even, int[] notEven)
429429
}
430430
}
431431

432-
[Theory, MemberData(nameof(GetToolchains))]
432+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
433433
public void VeryBigIntegersAreSupported(IToolchain toolchain) => CanExecute<WithVeryBigInteger>(toolchain);
434434

435435
public class WithVeryBigInteger
@@ -450,7 +450,7 @@ public void Method(BigInteger passed)
450450
}
451451
}
452452

453-
[Theory, MemberData(nameof(GetToolchains))]
453+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
454454
public void SpecialDoubleValuesAreSupported(IToolchain toolchain) => CanExecute<WithSpecialDoubleValues>(toolchain);
455455

456456
public class WithSpecialDoubleValues
@@ -495,7 +495,7 @@ public void Method(double passed, string name)
495495
}
496496
}
497497

498-
[Theory, MemberData(nameof(GetToolchains))]
498+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
499499
public void SpecialFloatValuesAreSupported(IToolchain toolchain) => CanExecute<WithSpecialFloatValues>(toolchain);
500500

501501
public class WithSpecialFloatValues
@@ -540,7 +540,7 @@ public void Method(float passed, string name)
540540
}
541541
}
542542

543-
[Theory, MemberData(nameof(GetToolchains))]
543+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
544544
public void SpecialDecimalValuesAreSupported(IToolchain toolchain) => CanExecute<WithSpecialDecimalValues>(toolchain);
545545

546546
public class WithSpecialDecimalValues
@@ -569,7 +569,7 @@ public void Method(decimal passed, string name)
569569
}
570570
}
571571

572-
[Theory, MemberData(nameof(GetToolchains))]
572+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
573573
public void DateTimeCanBeUsedAsArgument(IToolchain toolchain) => CanExecute<WithDateTime>(toolchain);
574574

575575
public class WithDateTime
@@ -590,7 +590,7 @@ public void Test(DateTime passed)
590590
}
591591
}
592592

593-
[Theory, MemberData(nameof(GetToolchains))]
593+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
594594
public void CustomTypeThatAlsoExistsInTheSystemNamespaceAsArgument(IToolchain toolchain) => CanExecute<CustomTypeThatAlsoExistsInTheSystemNamespace>(toolchain);
595595

596596
public class CustomTypeThatAlsoExistsInTheSystemNamespace
@@ -611,7 +611,7 @@ public void Test(Action passed)
611611
}
612612
}
613613

614-
[Theory, MemberData(nameof(GetToolchains))]
614+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
615615
public void EnumFlagsAreSupported(IToolchain toolchain) => CanExecute<WithEnumFlags>(toolchain);
616616

617617
public class WithEnumFlags
@@ -648,7 +648,7 @@ public void Test(LongFlagEnum passedLongFlagEnum, ByteFlagEnum passedByteFlagEnu
648648
}
649649
}
650650

651-
[Theory, MemberData(nameof(GetToolchains))]
651+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
652652
public void UndefinedEnumValuesAreSupported(IToolchain toolchain) => CanExecute<WithUndefinedEnumValue>(toolchain);
653653

654654
public class WithUndefinedEnumValue
@@ -674,7 +674,7 @@ public void Test(SomeEnum defined, SomeEnum undefined, SomeEnum undefinedNegativ
674674
}
675675
}
676676

677-
[Theory, MemberData(nameof(GetToolchains))]
677+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
678678
public void StaticMethodsAndPropertiesCanBeUsedAsSources_EnumerableOfObjects(IToolchain toolchain)
679679
=> CanExecute<WithStaticSources_EnumerableOfObjects>(toolchain);
680680

@@ -722,7 +722,7 @@ public void TestProperty(int argument)
722722
}
723723
}
724724

725-
[Theory, MemberData(nameof(GetToolchains))]
725+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
726726
public void StaticMethodsAndPropertiesCanBeUsedAsSources_EnumerableOfArrayOfObjects(IToolchain toolchain)
727727
=> CanExecute<WithStaticSources_EnumerableOfArrayOfObjects>(toolchain);
728728

@@ -769,7 +769,7 @@ public void TestProperty(int argument)
769769
}
770770
}
771771

772-
[Theory, MemberData(nameof(GetToolchains))]
772+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
773773
public void MethodsAndPropertiesFromAnotherClassCanBeUsedAsSources(IToolchain toolchain)
774774
=> CanExecute<ParamsSourcePointingToAnotherClass>(toolchain);
775775

@@ -805,7 +805,7 @@ public static IEnumerable<int> Property
805805
}
806806
}
807807

808-
[Theory, MemberData(nameof(GetToolchains))]
808+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
809809
public void VeryLongStringsAreSupported(IToolchain toolchain) => CanExecute<WithVeryLongString>(toolchain);
810810

811811
public class WithVeryLongString
@@ -829,7 +829,7 @@ public void Test(string first, string second)
829829
}
830830
}
831831

832-
[Theory, MemberData(nameof(GetToolchains))]
832+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
833833
public void ComplexStringPattersAreSupported(IToolchain toolchain) => CanExecute<Perf_Regex_Industry_RustLang_Sherlock>(toolchain);
834834

835835
public class Perf_Regex_Industry_RustLang_Sherlock

‎tests/BenchmarkDotNet.IntegrationTests/DisassemblyDiagnoserTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ public void Recursive()
8888
}
8989

9090
[Theory]
91-
[MemberData(nameof(GetAllJits))]
91+
[MemberData(nameof(GetAllJits), DisableDiscoveryEnumeration = true)]
9292
[Trait(Constants.Category, Constants.BackwardCompatibilityCategory)]
9393
public void CanDisassembleAllMethodCalls(Jit jit, Platform platform, Runtime runtime)
9494
{
@@ -107,7 +107,7 @@ public void CanDisassembleAllMethodCalls(Jit jit, Platform platform, Runtime run
107107
}
108108

109109
[Theory]
110-
[MemberData(nameof(GetAllJits))]
110+
[MemberData(nameof(GetAllJits), DisableDiscoveryEnumeration = true)]
111111
[Trait(Constants.Category, Constants.BackwardCompatibilityCategory)]
112112
public void CanDisassembleAllMethodCallsUsingFilters(Jit jit, Platform platform, Runtime runtime)
113113
{
@@ -132,7 +132,7 @@ public void CanDisassembleAllMethodCallsUsingFilters(Jit jit, Platform platform,
132132
}
133133

134134
[Theory]
135-
[MemberData(nameof(GetAllJits))]
135+
[MemberData(nameof(GetAllJits), DisableDiscoveryEnumeration = true)]
136136
[Trait(Constants.Category, Constants.BackwardCompatibilityCategory)]
137137
public void CanDisassembleGenericTypes(Jit jit, Platform platform, Runtime runtime)
138138
{
@@ -154,7 +154,7 @@ [Benchmark] public void JustReturn() { }
154154
}
155155

156156
[Theory]
157-
[MemberData(nameof(GetAllJits))]
157+
[MemberData(nameof(GetAllJits), DisableDiscoveryEnumeration = true)]
158158
[Trait(Constants.Category, Constants.BackwardCompatibilityCategory)]
159159
public void CanDisassembleInlinableBenchmarks(Jit jit, Platform platform, Runtime runtime)
160160
{

‎tests/BenchmarkDotNet.IntegrationTests/MemoryDiagnoserTests.cs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public class AccurateAllocations
5151
[Benchmark] public Task<int> AllocateTask() => Task.FromResult<int>(-12345);
5252
}
5353

54-
[Theory, MemberData(nameof(GetToolchains))]
54+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
5555
[Trait(Constants.Category, Constants.BackwardCompatibilityCategory)]
5656
public void MemoryDiagnoserIsAccurate(IToolchain toolchain)
5757
{
@@ -109,7 +109,7 @@ private void AllocateUntilGcWakesUp()
109109
}
110110
}
111111

112-
[Theory, MemberData(nameof(GetToolchains))]
112+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
113113
[Trait(Constants.Category, Constants.BackwardCompatibilityCategory)]
114114
public void MemoryDiagnoserDoesNotIncludeAllocationsFromSetupAndCleanup(IToolchain toolchain)
115115
{
@@ -135,7 +135,7 @@ public ulong TimeConsuming()
135135
}
136136
}
137137

138-
[Theory, MemberData(nameof(GetToolchains))]
138+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
139139
[Trait(Constants.Category, Constants.BackwardCompatibilityCategory)]
140140
public void EngineShouldNotInterfereAllocationResults(IToolchain toolchain)
141141
{
@@ -146,7 +146,7 @@ public void EngineShouldNotInterfereAllocationResults(IToolchain toolchain)
146146
}
147147

148148
// #1542
149-
[Theory, MemberData(nameof(GetToolchains))]
149+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
150150
[Trait(Constants.Category, Constants.BackwardCompatibilityCategory)]
151151
public void TieredJitShouldNotInterfereAllocationResults(IToolchain toolchain)
152152
{
@@ -162,7 +162,7 @@ public class NoBoxing
162162
[Benchmark] public ValueTuple<int> ReturnsValueType() => new ValueTuple<int>(0);
163163
}
164164

165-
[Theory, MemberData(nameof(GetToolchains))]
165+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
166166
[Trait(Constants.Category, Constants.BackwardCompatibilityCategory)]
167167
public void EngineShouldNotIntroduceBoxing(IToolchain toolchain)
168168
{
@@ -183,7 +183,7 @@ public class NonAllocatingAsynchronousBenchmarks
183183
[Benchmark] public ValueTask<int> CompletedValueTaskOfT() => new ValueTask<int>(default(int));
184184
}
185185

186-
[Theory, MemberData(nameof(GetToolchains))]
186+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
187187
[Trait(Constants.Category, Constants.BackwardCompatibilityCategory)]
188188
public void AwaitingTasksShouldNotInterfereAllocationResults(IToolchain toolchain)
189189
{
@@ -208,7 +208,7 @@ public void WithOperationsPerInvoke()
208208
private void DoNotInline(object left, object right) { }
209209
}
210210

211-
[Theory, MemberData(nameof(GetToolchains))]
211+
[Theory, MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
212212
[Trait(Constants.Category, Constants.BackwardCompatibilityCategory)]
213213
public void AllocatedMemoryShouldBeScaledForOperationsPerInvoke(IToolchain toolchain)
214214
{
@@ -235,7 +235,7 @@ public byte[] SixtyFourBytesArray()
235235
}
236236

237237
[TheoryEnvSpecific("Full Framework cannot measure precisely enough for low invocation counts.", EnvRequirement.DotNetCoreOnly)]
238-
[MemberData(nameof(GetToolchains))]
238+
[MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
239239
[Trait(Constants.Category, Constants.BackwardCompatibilityCategory)]
240240
public void AllocationQuantumIsNotAnIssueForNetCore21Plus(IToolchain toolchain)
241241
{
@@ -301,7 +301,7 @@ public void Allocate()
301301
}
302302

303303
[TheoryEnvSpecific("Full Framework cannot measure precisely enough", EnvRequirement.DotNetCoreOnly)]
304-
[MemberData(nameof(GetToolchains))]
304+
[MemberData(nameof(GetToolchains), DisableDiscoveryEnumeration = true)]
305305
[Trait(Constants.Category, Constants.BackwardCompatibilityCategory)]
306306
public void MemoryDiagnoserIsAccurateForMultiThreadedBenchmarks(IToolchain toolchain)
307307
{

0 commit comments

Comments
 (0)