Non-null dumpPath

timcassell · timcassell · commit 71054df9fc6a · 2025-10-29T18:18:15.000-04:00
diff --git a/src/BenchmarkDotNet/Disassemblers/ClrMdDisassembler.cs b/src/BenchmarkDotNet/Disassemblers/ClrMdDisassembler.cs
@@ -92,7 +92,7 @@ private DataTarget Attach(int processId)
             if (OsDetector.IsMacOS())
             {
                 // ClrMD does not support CreateSnapshotAndAttach on MacOS, and AttachToProcess is unreliable, so we have to create a dump file and load it.
-                string? dumpPath = Path.GetTempFileName();
+                string dumpPath = Path.GetTempFileName();
                 try
                 {
                     try
@@ -107,10 +107,7 @@ private DataTarget Attach(int processId)
                 }
                 finally
                 {
-                    if (dumpPath != null)
-                    {
-                        File.Delete(dumpPath);
-                    }
+                    File.Delete(dumpPath);
                 }
             }
             throw new NotSupportedException($"{System.Runtime.InteropServices.RuntimeInformation.OSDescription} is not supported");

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ private DataTarget Attach(int processId)`
`92`	`92`	`if (OsDetector.IsMacOS())`
`93`	`93`	`{`
`94`	`94`	`// ClrMD does not support CreateSnapshotAndAttach on MacOS, and AttachToProcess is unreliable, so we have to create a dump file and load it.`
`95`		`- string? dumpPath = Path.GetTempFileName();`
	`95`	`+ string dumpPath = Path.GetTempFileName();`
`96`	`96`	`try`
`97`	`97`	`{`
`98`	`98`	`try`
`@@ -107,10 +107,7 @@ private DataTarget Attach(int processId)`
`107`	`107`	`}`
`108`	`108`	`finally`
`109`	`109`	`{`
`110`		`- if (dumpPath != null)`
`111`		`- {`
`112`		`- File.Delete(dumpPath);`
`113`		`- }`
	`110`	`+ File.Delete(dumpPath);`
`114`	`111`	`}`
`115`	`112`	`}`
`116`	`113`	`throw new NotSupportedException($"{System.Runtime.InteropServices.RuntimeInformation.OSDescription} is not supported");`