Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preview 2 features #32034

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Add preview 2 features #32034

merged 4 commits into from
Mar 12, 2024

Conversation

tdykstra
Copy link
Contributor

@tdykstra tdykstra commented Mar 12, 2024

contributes to #31770


Internal previews

📄 File 🔗 Preview link
aspnetcore/release-notes/aspnetcore-9.0.md What's new in ASP.NET Core 9.0

@tdykstra tdykstra marked this pull request as ready for review March 12, 2024 14:32
Copy link
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT if you want to ... I'd recommend changing the broken sentence ("For example, the following code:" ... "Can now be simplified to the following code:") into two complete sentences. I suspect MT has a better shot if they're phrased as normal sentences.

@guardrex
Copy link
Collaborator

guardrex commented Mar 12, 2024

Side note for us all (@Rick-Anderson, @wadepickett) ... but u guys may already recall it ...

I was just reminded that under our new INCLUDE file scheme that updating an INCLUDE doesn't automatically update the Migration article. I'll probably flip the ms.date forward or backward or add/subtract a space at the end of a line to trigger the article to rebuild with an INCLUDE file change.

I made the Blazor Pre2 updates this morning (to the INCLUDE only). This PR will result in those changes being sucked into the article.

Copy link
Member

@danroth27 danroth27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@wadepickett wadepickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great with the update. Thanks Tom.

@tdykstra tdykstra merged commit 532fdf8 into dotnet:main Mar 12, 2024
3 checks passed
@tdykstra tdykstra deleted the net9p2 branch March 12, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants