Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api endpoint caching fix #312

Merged
merged 11 commits into from
Apr 24, 2019
Merged

Api endpoint caching fix #312

merged 11 commits into from
Apr 24, 2019

Conversation

samsteele
Copy link
Contributor

Extension currently caches the api endpoint with a scope code of "website" rather than "websites" - this results in an additional http request before each each api interaction to fetch the correct endpoint.

adeelq and others added 11 commits December 7, 2018 13:55
Related work items: #77362, #78740
Related work items: #54896, #81881
Related work items: #80891, #82804, #82924, #83210
Related work items: #80912, #83641, #84050, #84691
- We've fixed a bug that caused the catalog sync to skip products if invalid data keys were supplied.
- We've fixed a bug related to the use of `utf8_decode` in email templates (note this discontinues support for emojis in email subject lines).
- We've fixed a minor error thrown during the Engagement Cloud template sync.

Related work items: #85166, #85311, #85616
@adeelq adeelq self-requested a review April 24, 2019 08:46
@adeelq adeelq merged commit 3d22d79 into dotmailer:develop Apr 24, 2019
@adeelq
Copy link
Contributor

adeelq commented Apr 24, 2019

Thanks for your contribution

simon-letch pushed a commit that referenced this pull request May 22, 2019
**Improvements**

- We've improved the handling of double opt-in statuses in customer and subscriber syncs.
- We've made the resubscription process more robust, ensuring that as statuses change in Magento and Engagement Cloud, subscribers are not accidentally unsubscribed.
- We've moved our announcement feed checking tool into a cron script for efficiency.
- To improve onboarding for larger stores, we've decoupled our installation routine. Our SQL tables can now be populated via a configurable command line script, after the module has been activated.
- We've removed any dependency on Magento's Mage_Review module if review syncing is not active.
- We now automatically mark as sent any campaigns that Engagement Cloud indicates are still "Processing" after 2 hours, in order to ensure subsequent campaigns are sent.
- We've made various performance enhancements by refining our usage of some observers.

**Bub Fixes**

- We've fixed an issue with incorrect scope when saving the Engagement Cloud API endpoint URL. [External contribution](#312)
- We've repaired automation enrollments for guest subscribers when double opt-in is enabled in Magento.
- We've made the menu item for Abandoned Carts visible to all users with access to Engagement Cloud configuration.

Related work items: #68184, #79713, #86248, #87169, #88046, #88048, #88049, #88050, #88372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants