Fix capitalization style for UUID and constant names #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 08516ec.
mikolak
approved these changes
Feb 28, 2020
mikolak
added a commit
that referenced
this pull request
Mar 10, 2020
* Fix capitalization style for UUID and constant names (#437) * Fix capitalization of UUID in Service * Fix capitalization of UUID in ScanResult * Fix capitalization of UUID in Peripheral * Rename bytes to value * Fix capitalization of UUID in metadata strings in ScanResult * Fix constants capitalization in BleError * Revert "Fix capitalization of UUID in metadata strings in ScanResult" This reverts commit 08516ec. * Fix capitalization of UUID in managers for classes * Fix capitalization of UUID for InternalBleManager * Fix capitalization of UUID in CharacteristicsMixin * Fix capitalization of UUID in DevicesMixin * Rename bytes to value in internal classes * Add unit tests for Service (#439) * unit test for BleManager * [descriptor] override equals & hashcode functions * [tests] add: mock classes for managers * [service] add: service tests * [tests] create characteristics and descriptors using separate generators * [service][tests] cover generating transactionId when it's not specified * [service][tests] clear mocks interactions after each test * [service][tests] add missing test for getting all descriptors for specified characteristic Co-authored-by: Paweł Byszewski <4048063+pawelByszewski@users.noreply.github.com> * Bump MBA and lib version Co-authored-by: Łukasz Rejman <lukasz.rejman@polidea.com> Co-authored-by: Bartosz Wilk <bartosz.wilk@polidea.com> Co-authored-by: Paweł Byszewski <4048063+pawelByszewski@users.noreply.github.com>
mikolak
added a commit
that referenced
this pull request
May 7, 2020
* Fix capitalization style for UUID and constant names (#437) * Fix capitalization of UUID in Service * Fix capitalization of UUID in ScanResult * Fix capitalization of UUID in Peripheral * Rename bytes to value * Fix capitalization of UUID in metadata strings in ScanResult * Fix constants capitalization in BleError * Revert "Fix capitalization of UUID in metadata strings in ScanResult" This reverts commit 08516ec. * Fix capitalization of UUID in managers for classes * Fix capitalization of UUID for InternalBleManager * Fix capitalization of UUID in CharacteristicsMixin * Fix capitalization of UUID in DevicesMixin * Rename bytes to value in internal classes * Add unit tests for Service (#439) * unit test for BleManager * [descriptor] override equals & hashcode functions * [tests] add: mock classes for managers * [service] add: service tests * [tests] create characteristics and descriptors using separate generators * [service][tests] cover generating transactionId when it's not specified * [service][tests] clear mocks interactions after each test * [service][tests] add missing test for getting all descriptors for specified characteristic Co-authored-by: Paweł Byszewski <4048063+pawelByszewski@users.noreply.github.com> * Descriptor unit tests (#441) * unit test for BleManager * [descriptor] override equals & hashcode functions * [tests] add: mock classes for managers * [tests] create characteristics and descriptors using separate generators * [descriptor] add: tests * [descriptor] fix: test names * [tests] move all mocks declarations to one aggregate file * [ble-manager][test] add matcher to always check objects' references * [descriptor][test] add tests that check uniquity of transactionId Co-authored-by: pawelByszewski <pawell.b@gmail.com> * [iOS] Fixed casting of Bool arguments received from dart (#451) * Remove root level `Flutter User Facing API.dart` (#455) * rename root level file naming interfered with certain build_runner code generators * remove flutter_user_facing_api.dart * Release 2.2.4 Co-authored-by: Łukasz Rejman <lukasz.rejman@polidea.com> Co-authored-by: Bartosz Wilk <bartosz.wilk@polidea.com> Co-authored-by: Paweł Byszewski <4048063+pawelByszewski@users.noreply.github.com> Co-authored-by: pawelByszewski <pawell.b@gmail.com> Co-authored-by: Tomasz Bogusz <tomasz.bogusz@polidea.com> Co-authored-by: Dustin Graham <dcgraham7@gmail.com>
mikolak
added a commit
that referenced
this pull request
Jun 10, 2020
* Fix capitalization style for UUID and constant names (#437) * Fix capitalization of UUID in Service * Fix capitalization of UUID in ScanResult * Fix capitalization of UUID in Peripheral * Rename bytes to value * Fix capitalization of UUID in metadata strings in ScanResult * Fix constants capitalization in BleError * Revert "Fix capitalization of UUID in metadata strings in ScanResult" This reverts commit 08516ec. * Fix capitalization of UUID in managers for classes * Fix capitalization of UUID for InternalBleManager * Fix capitalization of UUID in CharacteristicsMixin * Fix capitalization of UUID in DevicesMixin * Rename bytes to value in internal classes * Add unit tests for Service (#439) * unit test for BleManager * [descriptor] override equals & hashcode functions * [tests] add: mock classes for managers * [service] add: service tests * [tests] create characteristics and descriptors using separate generators * [service][tests] cover generating transactionId when it's not specified * [service][tests] clear mocks interactions after each test * [service][tests] add missing test for getting all descriptors for specified characteristic Co-authored-by: Paweł Byszewski <4048063+pawelByszewski@users.noreply.github.com> * Descriptor unit tests (#441) * unit test for BleManager * [descriptor] override equals & hashcode functions * [tests] add: mock classes for managers * [tests] create characteristics and descriptors using separate generators * [descriptor] add: tests * [descriptor] fix: test names * [tests] move all mocks declarations to one aggregate file * [ble-manager][test] add matcher to always check objects' references * [descriptor][test] add tests that check uniquity of transactionId Co-authored-by: pawelByszewski <pawell.b@gmail.com> * [iOS] Fixed casting of Bool arguments received from dart (#451) * Remove root level `Flutter User Facing API.dart` (#455) * rename root level file naming interfered with certain build_runner code generators * remove flutter_user_facing_api.dart * Handle destroyClient call on iOS (#461) * Handle destroyClient call on iOS * Add missing semicolon * [Android] Fix race condition in ConnectionStateStreamHanderl (#468) (#469) * [Android] Fix race condition in ConnectionStateStreamHanderl (#468) Add extra null check and synchronized block in async callback * [Android] Move json generation back into try catch block (#468) * Update pubspec format (#418) * Remove author field * Add supported platforms * Enforce Flutter version * Release 2.2.5 Co-authored-by: Łukasz Rejman <lukasz.rejman@polidea.com> Co-authored-by: Bartosz Wilk <bartosz.wilk@polidea.com> Co-authored-by: Paweł Byszewski <4048063+pawelByszewski@users.noreply.github.com> Co-authored-by: pawelByszewski <pawell.b@gmail.com> Co-authored-by: Tomasz Bogusz <tomasz.bogusz@polidea.com> Co-authored-by: Dustin Graham <dcgraham7@gmail.com> Co-authored-by: Leo Huang <leo.tx.huang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some places there was a different capitalization for the
UUIDpart of names. This PR capitalizes allUUIDs like regular words -Uuid, except strings and comments. Reference: DO capitalize acronyms and abbreviations longer than two letters like words.I also found
SCREAMING_CAPSandUpperCamelCasestyles in constant names inble_error.dart, so I also fixed it by applying the style preferred by Dart. Reference: PREFER using lowerCamelCase for constant names.There was a naming inconsistency for a parameter holding the value of a characteristic. In some places it was named
bytes. I renamed it tovaluewherever I found it.