[resolvers] Add generateInternalResolversIfNeeded.__isTypeOf
#10138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: da2e301 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eddeee888
commented
Sep 15, 2024
| @@ -675,8 +674,8 @@ export class BaseResolversVisitor< | |||
| protected _hasReferencedResolversUnionTypes = false; | |||
| protected _hasReferencedResolversInterfaceTypes = false; | |||
| protected _resolversUnionTypes: Record<string, string> = {}; | |||
| protected _resolversUnionParentTypes: Record<string, string> = {}; | |||
There was a problem hiding this comment.
_resolversUnionParentTypes was used previously but not needed anymore. Removing in this PR as a drive-by
Base automatically changed from
federation-no-resolve-reference-if-not-resolvable
to
master
October 8, 2024 12:15
eddeee888
force-pushed
the
internal-resolvers-is-type-of
branch
from
f3d0d03
to
600a615
Compare
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-codegen/visitor-plugin-common |
5.5.0-alpha-20241014102122-da2e301d5dcf60afe319d5c2bc73b5b0d5fd3be7 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-document-nodes |
4.0.11-alpha-20241014102122-da2e301d5dcf60afe319d5c2bc73b5b0d5fd3be7 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/gql-tag-operations |
4.0.11-alpha-20241014102122-da2e301d5dcf60afe319d5c2bc73b5b0d5fd3be7 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-operations |
4.3.1-alpha-20241014102122-da2e301d5dcf60afe319d5c2bc73b5b0d5fd3be7 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-resolvers |
4.4.0-alpha-20241014102122-da2e301d5dcf60afe319d5c2bc73b5b0d5fd3be7 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typed-document-node |
5.0.11-alpha-20241014102122-da2e301d5dcf60afe319d5c2bc73b5b0d5fd3be7 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript |
4.1.1-alpha-20241014102122-da2e301d5dcf60afe319d5c2bc73b5b0d5fd3be7 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/client-preset |
4.5.0-alpha-20241014102122-da2e301d5dcf60afe319d5c2bc73b5b0d5fd3be7 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/graphql-modules-preset |
4.0.11-alpha-20241014102122-da2e301d5dcf60afe319d5c2bc73b5b0d5fd3be7 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/plugin-helpers |
5.1.0-alpha-20241014102122-da2e301d5dcf60afe319d5c2bc73b5b0d5fd3be7 |
npm ↗︎ unpkg ↗︎ |
eddeee888
changed the title
generateInternalResolversIfNeeded. __isTypeOfgenerateInternalResolversIfNeeded.__isTypeOf
💻 Website PreviewThe latest changes are available as preview in: https://dab09720.graphql-code-generator.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR compliments #9989 and should be merged after.
Previously, we always generate
__isTypeOftype which means consumers may try to implement it, even when they don't have to.This PR adds
generateInternalResolversIfNeeded.__isTypeOfto conditionally generate this resolver only for implementing types or union membersType of change
Please delete options that are not relevant.
How Has This Been Tested?