Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update cosmiconfig in @graphql-codegen/cli #9420

Closed
shellscape opened this issue May 17, 2023 · 1 comment
Closed

Please update cosmiconfig in @graphql-codegen/cli #9420

shellscape opened this issue May 17, 2023 · 1 comment

Comments

@shellscape
Copy link

Which packages are impacted by your issue?

@graphql-codegen/cli

Describe the bug

@graphql-codegen/cli is using a version of cosmiconfig that is a full major version (plus) behind. That major version (7.x) contains a particular CVE that is impossible to get around: GHSA-f9xv-q969-pqx4

Overriding the version of yaml with a package manager results in a crash of cosmiconfig and subsequently @graphql-codegen/cli as there are breaking changes with the version of yaml that cosmiconfig@7 uses, and the latest version which resolves the CVE yaml@2.2.2. Additionally, cosmiconfig@8 no longer uses the yaml package.

Offending line is here: https://github.com/dotansimha/graphql-code-generator/blob/master/packages/graphql-codegen-cli/package.json#L61

Your Example Website or App

n/a

Steps to Reproduce the Bug or Issue

Doesn't require a reproduction, as this is strictly a dependency update.

Expected behavior

A reasonably updated version of cosmiconfig and other dependencies would be used.

Screenshots or Videos

No response

Platform

  • OS: all
  • NodeJS: LTS
  • graphql version: 15+
  • @graphql-codegen/* version(s): 3.3.1

Codegen Config File

No response

Additional context

No response

@shellscape shellscape changed the title Please update cosmiconfig in @ Please update cosmiconfig in @graphql-codegen/cli May 17, 2023
@n1ru4l
Copy link
Collaborator

n1ru4l commented May 23, 2023

done as part of #9449 and will be released soon.

@n1ru4l n1ru4l closed this as completed May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants