From 3a3202fbb671617d34075040e7aa8129650bbcb1 Mon Sep 17 00:00:00 2001 From: Charly POLY <1252066+charlypoly@users.noreply.github.com> Date: Tue, 25 Oct 2022 12:22:29 +0200 Subject: [PATCH] fix(client-preset): allow non-typescript plugins (#8523) --- .changeset/fair-mugs-reflect.md | 5 +++++ packages/presets/client/src/index.ts | 6 ++++-- 2 files changed, 9 insertions(+), 2 deletions(-) create mode 100644 .changeset/fair-mugs-reflect.md diff --git a/.changeset/fair-mugs-reflect.md b/.changeset/fair-mugs-reflect.md new file mode 100644 index 00000000000..8e84d1560e1 --- /dev/null +++ b/.changeset/fair-mugs-reflect.md @@ -0,0 +1,5 @@ +--- +'@graphql-codegen/client-preset': patch +--- + +allow non-typescript plugins diff --git a/packages/presets/client/src/index.ts b/packages/presets/client/src/index.ts index 4e28dd44686..036eea9d729 100644 --- a/packages/presets/client/src/index.ts +++ b/packages/presets/client/src/index.ts @@ -73,8 +73,10 @@ export const preset: Types.OutputPreset = { throw new Error('[client-preset] target output should be a directory, ex: "src/gql/"'); } - if (options.plugins.length > 0) { - throw new Error('[client-preset] providing `plugins` with `preset: "client" leads to duplicated generated types'); + if (options.plugins.length > 0 && Object.keys(options.plugins).some(p => p.startsWith('typescript'))) { + throw new Error( + '[client-preset] providing typescript-based `plugins` with `preset: "client" leads to duplicated generated types' + ); } const reexports: Array = [];