Use stream to make code more concise

Author: leonardehrenfried

packages/plugins/java/java/src/visitor.ts

@@ -73,7 +73,6 @@ export class JavaResolversVisitor extends BaseVisitor<
     }
 
     if (this._addListImport) {
-      allImports.push(`java.util.ArrayList`);
       allImports.push(`java.util.List`);
       allImports.push(`java.util.stream.Collectors`);
     }
@@ -238,15 +237,9 @@ export class JavaResolversVisitor extends BaseVisitor<
           }
           return indentMultiline(
             `if (args.get("${arg.name.value}") != null) {
-  this.${arg.name.value} = new ArrayList<${typeToUse.baseType}>();
-  for (var o : (${this.config.listType}<Map<String, Object>>) args.get("${arg.name.value}")) {
-    if (o != null) {
-      this.${arg.name.value}.add(new ${typeToUse.baseType}(o));
-    }
-    else {
-      this.${arg.name.value}.add(null);
-    }
-  }
+  this.${arg.name.value} = ((${this.config.listType}<Map<String, Object>>) args.get("${arg.name.value}")).stream()
+    .map(o -> o == null ? null : new ${typeToUse.baseType}(o))
+    .collect(Collectors.toList());
 }`,
             3,
           );

packages/plugins/java/java/tests/java.spec.ts

@@ -158,15 +158,9 @@ describe('Java', () => {
           if (args != null) {
             this.f = (Iterable<String>) args.get("f");
             if (args.get("g") != null) {
-              this.g = new ArrayList<SearchUserInput>();
-              for (var o : (Iterable<Map<String, Object>>) args.get("g")) {
-                if (o != null) {
-                  this.g.add(new SearchUserInput(o));
-                }
-                else {
-                  this.g.add(null);
-                }
-              }
+              this.g = ((Iterable<Map<String, Object>>) args.get("g")).stream()
+               .map(o -> o == null ? null : new SearchUserInput(o))
+               .collect(Collectors.toList());
             }
           }
         }