Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Thumbnails in Content Search Screen #29098

Closed
fishsmith opened this issue Jul 2, 2024 · 5 comments · Fixed by #29278
Closed

Improve Thumbnails in Content Search Screen #29098

fishsmith opened this issue Jul 2, 2024 · 5 comments · Fixed by #29278

Comments

@fishsmith
Copy link
Collaborator

Define the Problem

Poor thumbnail quality for smaller images and SVGs
Smaller images are pixelated in thumbnail view (converted to 500px x 500px).
We shouldn't be converting SVG images to WebP. SVGs should always stay SVG to maintain their vector format.

Who's Facing the Problem?

Content Contributors

Screenshot or Video

Screenshot 2024-07-02 at 5 00 55 PM

Relevant Links and Resources

No response

Assumptions & Initiation Needs

No response

@fishsmith
Copy link
Collaborator Author

Also, the thumbnails shouldn't be cut off. The background should have the size set to "background-size: contain;" NOT "background-size: cover;"

@fishsmith
Copy link
Collaborator Author

Screenshot 2024-07-02 at 5 26 37 PM

@zJaaal zJaaal self-assigned this Jul 18, 2024
@zJaaal zJaaal linked a pull request Jul 18, 2024 that will close this issue
@zJaaal
Copy link
Contributor

zJaaal commented Jul 19, 2024

Note to QA

Right now there's no way to know at a contentlet level, the sizes of an image to identify if it is an Icon or a big Image. This means that I didn't find a way to apply the same styles for small images that are not SVGs, right now this fix just work for SVGs which are mostly icons.

@rjvelazco
Copy link
Contributor

Passed Internal QA

  • Tested on docker image: [dotcms/dotcms:trunk_ b00ffaf]

Video

iqa-29098-improve-thumbnails-in-content-search-screen.mov

@bryanboza
Copy link
Member

Fixed, tested on the latest trunk and now it is working better regarding small images and SVG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants