Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Add New Device" Button to "Edit" Icon #28455

Closed
bryanboza opened this issue May 7, 2024 · 3 comments · Fixed by #29033
Closed

Change "Add New Device" Button to "Edit" Icon #28455

bryanboza opened this issue May 7, 2024 · 3 comments · Fixed by #29033

Comments

@bryanboza
Copy link
Member

bryanboza commented May 7, 2024

Problem Statement

The "Add New Device" button in the interface currently does not add a new device but rather allows users to edit existing device settings. This misleads users, affecting usability and efficiency.
image

Then we need to change this icon by a edit pen.

Steps to Reproduce

  • Login as admin
  • Edit any page
  • Open the preview drop-down
  • In the devices list click in the + button on the top of the list
  • Observe that the interface transitions to an edit mode for an existing device rather than adding a new device.

Acceptance Criteria

The "Add New Device" button should be replaced with an "Edit" icon that accurately reflects its function.
The new icon should be tested across different browsers and devices to ensure it performs consistently.
The tooltip and accessibility labels for the button should be updated to "Edit Device."

dotCMS Version

Tested on master // Docker // FF

Proposed Objective

Quality Assurance

Proposed Priority

Priority 2 - Important

@melissarojas-dotcms
Copy link

Link to Figma with the new icon.

@zJaaal
Copy link
Contributor

zJaaal commented Jun 28, 2024

IQA Passed

Icon is updated.

Docker Image: [dotcms/dotcms:trunk_743e6da]

Screenshot

Screen.Recording.2024-06-28.at.1.19.19.PM.mov

@zJaaal zJaaal removed their assignment Jun 28, 2024
@zJaaal zJaaal closed this as completed Jun 28, 2024
@bryanboza
Copy link
Member Author

bryanboza commented Jun 28, 2024

Fixed, tested on trunk // Docker

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants