Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit EMA: Decouple Edit Page Nav Bar from Router Module #26966

Closed
Tracked by #26644
zJaaal opened this issue Dec 11, 2023 · 2 comments
Closed
Tracked by #26644

Edit EMA: Decouple Edit Page Nav Bar from Router Module #26966

zJaaal opened this issue Dec 11, 2023 · 2 comments

Comments

@zJaaal
Copy link
Contributor

zJaaal commented Dec 11, 2023

Parent Issue

#26644

Task

The current Nav Bar from Edit Page is tied up to the router of edit-page we need to make this component as dumb as possible, to make it more reusable.

Proposed Objective

Same as Parent Issue

Proposed Priority

Priority 3 - Average

Acceptance Criteria

  • This component should only emit the link we need to navigate.
  • This component should take all that it needs through Angular Inputs.
  • This component should not handle the logic to create the Nav Bar, it should take the model it needs to render it.
  • This component should work exactly as it works right now, but with the advantage of being reusable.

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@fmontes fmontes changed the title Edit EMA: Disengage old Edit Page Nav Bar from Router Module Edit EMA: Decouple Edit Page Nav Bar from Router Module Dec 11, 2023
@zJaaal zJaaal self-assigned this Dec 12, 2023
@zJaaal
Copy link
Contributor Author

zJaaal commented Dec 12, 2023

Closed in favor of this #26965

@zJaaal zJaaal closed this as completed Dec 12, 2023
@fmontes
Copy link
Member

fmontes commented Dec 12, 2023

We decided not to to the decoupling because it will be take too much time to implement and we have a set date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants