Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEO - Small UX fixes #26359

Closed
damen-dotcms opened this issue Oct 4, 2023 · 3 comments · Fixed by #26388
Closed

SEO - Small UX fixes #26359

damen-dotcms opened this issue Oct 4, 2023 · 3 comments · Fixed by #26388

Comments

@damen-dotcms
Copy link
Contributor

Screenshot_2023-10-04_16-10-30.png

Parent Issue

  • Red: The icons are aligned in the center of the item

  • Purple: We are missing a scroll bar

  • Blue: We are missing a divider line between the default and user devices.

  • Green: The Twitter Title changed.

Problem Statement

Steps to Reproduce

Acceptance Criteria

  • Red: The icons should be aligned with the title of each item, please make sure that even the Social Media titles are aligned (Please also check if the size of the icon is the same as the design)

  • Purple: Add a scrollbar in each of the device columns.

  • Blue: Add a divider line between the default and user devices.

  • Green: The Twitter should be changed to:
    X (Formerly Twitter)

dotCMS Version

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

Assumptions & Initiation Needs

Quality Assurance Notes & Workarounds

Sub-Tasks & Estimates


Reported by: Melissa Rojas Rodríguez (melissa.rojas@dotcms.com)

Source URL: https://dotcms-qa-master.dotcms.site/dotAdmin/#/edit-page/content?url=%2Fblog%2Fpost%2Ffrench-polynesia-everything-you-need-to-know&host_id=48190c8c-42c4-46af-8d1a-0cd5db894797&language_id=1&device_inode=

Issue details: Open in Marker.io

Device typedesktop
BrowserChrome 117.0.0.0
Screen Size1512 x 982
OSOS X 13.5.2
Viewport Size1512 x 913
Zoom Level100%
Pixel Ratio@​2x
@dcolina
Copy link
Contributor

dcolina commented Oct 13, 2023

Internal QA: Needs work.

@manuelrojas I am not sure whether there is a bug, but I have some doubt about the scroll behavior of the Devices panel.

Following the acceptance criteria I think it should be two scroll bars and it seems to have only one.

Screen.Recording.2023-10-13.at.11.23.07.mov

@dcolina
Copy link
Contributor

dcolina commented Oct 19, 2023

Internal QA: PASSED.

@josemejias11
Copy link
Contributor

Approved: Tested on master_3c41b76_SNAPSHOT, Docker, macOS 13.0, FF v113.0
Screenshot 2023-10-19 at 10 35 20 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants