Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Manifest to check integrity before ingesting bundle #20895

Closed
freddyucv opened this issue Sep 1, 2021 · 1 comment
Closed

Use Manifest to check integrity before ingesting bundle #20895

freddyucv opened this issue Sep 1, 2021 · 1 comment

Comments

@freddyucv
Copy link

freddyucv commented Sep 1, 2021

Right now if we send a Push publish request and it failed with any conflicts then we need to run the integrity checker, resolve conflicts and after that send the PP again.

The idea is use the information in the Manifest file to run the Integrity Checker in the receiver, just for the assets included in the Bundle to check if any conflicts exists before run the Handlers.

We are going to create a new filter's property to set if the Integrity Checker must run in the receiver or not, this new properties could be named something like integrity and it is going to have 3 possibles values:

-none(default): the Integrity Checker will not run before Push Publish in the receiver.
-fix: The Integrity checker will run and fix the conflicts (if any exists) in the receiver.
-notify: The Integrity Checker will run in the receiver but it will not fix the conflicts if there is any then they are notify in the sender.

The step by step to run the Integrity Checker in the receiver, when publish from the sender, will be:

  1. Open the Push Publish dialog
  2. Select any filter with the integrity property not equals to none.
  3. The Bundle is generated and sent to the receiver
  4. In the receiver the BundlePublisher gets the sender’s data from the Manifest and run the IntegrityUtil#completeCheckIntegrity method to start the Integrity Checker process.
  5. If there are no conflicts then bundle processing continues as normal.
  6. If conflicts are detected then it acts depending upon the filter's integrity property value:
    a. If the value is equals to fix then it run the IntegrityUtil#fixConflicts method to fix the conflicts in the receiver,
    and after it run the publishing.
    b. If the value is equals to notify then the user will get a report with the conflicts

Tt should work for Upload bundle too.

If the integrity property value is equals to notify then the conflicts are reported showing an icon in the Status / History list next to the status message, clicking the icon will show the conflict dialog (the same use currently).

@freddyucv freddyucv added this to the Falcon Current milestone Sep 1, 2021
@freddyucv freddyucv added the Epic label Sep 1, 2021
@dsilvam dsilvam removed this from the Falcon Current milestone Oct 26, 2021
@freddyucv freddyucv changed the title Run Integrity Checker before Publishing a Bundler in the receiver Use Manifest to check integrity before ingesting bundle Jan 27, 2022
@stale
Copy link

stale bot commented Dec 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 1, 2022
@stale stale bot closed this as completed Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants