From 669e6acadde61547604721d53eb12966bc59e714 Mon Sep 17 00:00:00 2001
From: Daniel Colina <daniel.colina@dotcms.com>
Date: Tue, 20 Aug 2024 18:41:27 +0200
Subject: [PATCH] #28259 fixing some potential errors.

---
 .github/actions/core-cicd/deployment/deploy-sdk-npm/action.yml | 3 +++
 .../actions/core-cicd/notification/notify-slack/action.yaml    | 2 +-
 .github/workflows/cicd_3-trunk.yml                             | 2 +-
 .github/workflows/cicd_comp_deployment-phase.yml               | 2 +-
 4 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/.github/actions/core-cicd/deployment/deploy-sdk-npm/action.yml b/.github/actions/core-cicd/deployment/deploy-sdk-npm/action.yml
index 8edf09198881..c8e015e1b471 100644
--- a/.github/actions/core-cicd/deployment/deploy-sdk-npm/action.yml
+++ b/.github/actions/core-cicd/deployment/deploy-sdk-npm/action.yml
@@ -23,6 +23,9 @@ outputs:
   npm-package-version:
     description: 'SDK libs - NPM package version'
     value: ${{ steps.next_version.outputs.next_version }}
+  published:
+    description: 'SDK libs - Published'
+    value: ${{ steps.next_version.outputs.publish }}
 runs:
   using: "composite"
   steps:
diff --git a/.github/actions/core-cicd/notification/notify-slack/action.yaml b/.github/actions/core-cicd/notification/notify-slack/action.yaml
index e280954ee76f..d954ca7bd10f 100644
--- a/.github/actions/core-cicd/notification/notify-slack/action.yaml
+++ b/.github/actions/core-cicd/notification/notify-slack/action.yaml
@@ -25,7 +25,7 @@ runs:
                 "type": "section",
                 "text": {
                   "type": "mrkdwn",
-                  "text": ${{ inputs.payload }}
+                  "text": "${{ inputs.payload }}"
                 }
               }
             ]
diff --git a/.github/workflows/cicd_3-trunk.yml b/.github/workflows/cicd_3-trunk.yml
index a74d48369508..1d0c13796125 100644
--- a/.github/workflows/cicd_3-trunk.yml
+++ b/.github/workflows/cicd_3-trunk.yml
@@ -101,7 +101,7 @@ jobs:
     uses: ./.github/workflows/cicd_comp_deployment-phase.yml
     with:
       artifact-run-id: ${{ needs.initialize.outputs.artifact-run-id }}
-      publish-npm-sdk-libs: ${{ needs.initialize.outputs.sdk_libs != false && github.event_name != 'workflow_dispatch' }}
+      publish-npm-sdk-libs: ${{ needs.initialize.outputs.sdk_libs != 'false' && github.event_name != 'workflow_dispatch' }}
       environment: trunk
     secrets:
       DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
diff --git a/.github/workflows/cicd_comp_deployment-phase.yml b/.github/workflows/cicd_comp_deployment-phase.yml
index e1a9785541e1..460a3135dbcf 100644
--- a/.github/workflows/cicd_comp_deployment-phase.yml
+++ b/.github/workflows/cicd_comp_deployment-phase.yml
@@ -161,7 +161,7 @@ jobs:
 
       # Send Slack notification for SDK publication (if required)          
       - name: Slack Notification (SDK announcement)
-        if: inputs.publish-npm-sdk-libs
+        if: success() && steps.sdks_publish.outputs.published == 'true'
         uses: ./.github/actions/core-cicd/notification/notify-slack
         with:
           channel-id: "log-sdk-libs"