Clean up schema

Author: Donatas Stundys

app/graphql/mutations/add_comment.rb

@@ -1,5 +1,5 @@
 class Mutations::AddComment < Mutations::Base
-  argument :articleId, ID, required: true, as: :article_id
+  argument :article_id, ID, required: true
   argument :body, String, required: true
 
   field :comment, Types::CommentType, null: true

app/graphql/mutations/create_article.rb

@@ -2,7 +2,7 @@ class Mutations::CreateArticle < Mutations::Base
   argument :title, String, required: true
   argument :description, String, required: true
   argument :body, String, required: true
-  argument :tagList, [String], required: true, as: :tag_list
+  argument :tag_list, [String], required: true
 
   field :article, Types::ArticleType, null: true
   field :errors, [Types::UserErrorType], null: false

app/graphql/mutations/update_article.rb

@@ -3,7 +3,7 @@ class Mutations::UpdateArticle < Mutations::Base
   argument :title, String, required: true
   argument :description, String, required: true
   argument :body, String, required: true
-  argument :tagList, [String], required: true, as: :tag_list
+  argument :tag_list, [String], required: true
 
   field :article, Types::ArticleType, null: true
   field :errors, [Types::UserErrorType], null: false

app/graphql/schema.graphql

@@ -16,7 +16,7 @@ type AddCommentPayload {
 }
 
 type Article {
-  author: User!
+  author: User
   body: String!
   comments: [Comment!]!
   createdAt: DateTime!
@@ -202,11 +202,9 @@ type Query {
   articles(
     # Returns the elements in the list that come after the specified cursor.
     after: String
-    authoredBy: String
 
     # Returns the elements in the list that come before the specified cursor.
     before: String
-    favoritedBy: String
 
     # Returns the first _n_ elements from the list.
     first: Int
@@ -366,7 +364,7 @@ type UserEdge {
 
 type UserError {
   message: String!
-  path: [String!]
+  path: String
 }
 
 type Viewer {

app/graphql/types/article_type.rb

@@ -11,7 +11,7 @@ class Types::ArticleType < GraphQL::Schema::Object
   field :updated_at, Types::DateTimeType, null: false
   field :viewer_has_favorited, Boolean, null: false
   field :favorites_count, Int, null: false
-  field :author, Types::UserType, null: false
+  field :author, Types::UserType, null: true
   field :comments, [Types::CommentType], null: false
 
   def viewer_has_favorited

app/graphql/types/query_type.rb

@@ -13,24 +13,10 @@ def user(username:)
 
   field :articles, Types::ArticleType.connection_type, null: false do
     argument :tag, String, required: false
-    argument :authoredBy, String, required: false, as: :authored_by
-    argument :favoritedBy, String, required: false, as: :favorited_by
   end
   def articles(tag: nil, authored_by: nil, favorited_by: nil)
     articles = Article.all
 
-    if authored_by.present?
-      author = User.find_by(username: authored_by)
-      raise GraphQL::ExecutionError, 'User not found' if author.blank?
-      articles.where!(author: author)
-    end
-
-    if favorited_by.present?
-      user = User.find_by(username: favorited_by)
-      raise GraphQL::ExecutionError, 'User not found' if user.blank?
-      articles.where!(id: user.favorite_article_ids)
-    end
-
     if tag.present?
       articles = articles.tagged_with(tag)
     end

app/graphql/types/user_error_type.rb

@@ -2,5 +2,5 @@ class Types::UserErrorType < GraphQL::Schema::Object
   graphql_name 'UserError'
 
   field :message, String, null: false
-  field :path, [String], null: true
+  field :path, String, null: true
 end