Fix kotest#2793 by handling the edge cases of lenient json number comparison (kotest#2794)

Author: zak-cloudnc

kotest-assertions/kotest-assertions-json/src/commonMain/kotlin/io/kotest/assertions/json/compare.kt

@@ -377,23 +377,15 @@ private fun compareNumbers(
    }
 }
 
-private val fractionalZeroesRegex =
-   """(\.\d*)0+""".toRegex()
 
 private fun compareNumberNodes(
    path: List<String>,
    expected: JsonNode.NumberNode,
    actual: JsonNode.NumberNode
 ): JsonError? {
-   /**
-    * Removes insignificant part of a number. e.g. 1.0 -> 1 or 3.1400 -> 3.14
-    */
-   fun trimInsignificant(value: String): String =
-      value.replace(fractionalZeroesRegex) { it.groupValues[1].trimEnd('0') }
-         .trimEnd('.')
 
    return when {
-      trimInsignificant(expected.asString()) == trimInsignificant(actual.asString()) -> null
+      expected.lenientEquals(actual) -> null
       else -> JsonError.UnequalValues(path, expected.content, actual.content)
    }
 }

kotest-assertions/kotest-assertions-json/src/commonMain/kotlin/io/kotest/assertions/json/nodes.kt

@@ -37,7 +37,27 @@ sealed class JsonNode {
          private val exponentRegex = """.+[eE][+-]?\d+""".toRegex()
       }
 
-      fun asString() = if (content.matches(exponentRegex)) content.toDouble().toString() else content
+      fun lenientEquals(other: NumberNode): Boolean {
+
+         if (other.content == content) return true
+
+         // if one or the other is exponent notation, we must compare by parsed value
+         if (content.matches(exponentRegex) xor other.content.matches(exponentRegex)) {
+            return content.toDouble() == other.content.toDouble()
+         }
+
+         val fractionalZeroesRegex = """(\.\d*)0+$""".toRegex()
+         /**
+          * Removes insignificant part of a number. e.g. 1.0 -> 1 or 3.1400 -> 3.14
+          */
+         fun trimInsignificant(value: String): String =
+            value.replace(fractionalZeroesRegex) { it.groupValues[1].trimEnd('0') }
+               .trimEnd('.')
+
+         return trimInsignificant(content) == trimInsignificant(other.content)
+
+      }
+
    }
 
    object NullNode : JsonNode(), ValueNode

kotest-assertions/kotest-assertions-json/src/jvmTest/kotlin/com/sksamuel/kotest/tests/json/JsonLiteralsTest.kt

@@ -46,6 +46,10 @@ class JsonLiteralsTest : FunSpec(
             "1000.0" shouldEqualJson "1000"
             "5E0" shouldEqualJson "5.0"
             "2E-1" shouldEqualJson "0.2"
+            shouldFail {
+               "1.0E-3" shouldEqualJson "0.0001"
+            }
+            "1.0E-4" shouldEqualJson "0.0001"
          }
 
          test("comparing high-precision floating point numbers") {