Smoll QoL additions #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Seems I've wrongly committed some extra log messages. We should get rid of it pre-merge. |
burgesQ
force-pushed
the
main-q-stuffs
branch
2 times, most recently
from
f4181ef to
7fdbd12
Compare
burgesQ
force-pushed
the
main-q-stuffs
branch
3 times, most recently
from
0aa8280 to
16175fe
Compare
The following payload would pass: `42/ssh,["resize",{"cols":123,"rows":41}]`
While this one would fail: `42/logview,["resize",{"cols":124,"rows":34}]`
Turns out some counter done on the sliced message did not take into
account already processed tokens
burgesQ
force-pushed
the
main-q-stuffs
branch
from
16175fe to
d95eba9
Compare
burgesQ
force-pushed
the
main-q-stuffs
branch
from
a6b8aab to
8b08c83
Compare
burgesQ
force-pushed
the
main-q-stuffs
branch
from
8b08c83 to
4a6aece
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conn.RequestHeaders()(thread safe)Conn.RequestQuery()(thread safe)Conn.SetData&Conn.GetDatamethods (see atomic.Pointer for hint about the whys)/socket.io/) (only std' http.Server ATM)