Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow collation/partitioning of notifications based on expiry and path #2

Open
dennisjbell opened this issue Sep 17, 2018 · 4 comments

Comments

@dennisjbell
Copy link
Member

dennisjbell commented Sep 17, 2018

It would be really great if notifications could be sent different shout targets based on the path of the expired certs. This is mainly because groups of certs are handled by different teams in an organization. Furthermore, (and I confess to no knowing if this is already the case or not) it'd be best if the notification was grouped for all expired (or expiring) certs under that path and expiry timeframe, similar to the current dashboard's expired, in 2 week, in 4 weeks.

@thomasmitchell
Copy link
Collaborator

I would imagine this would require path specification by a list of path( regex)?s to include and exclude, such that you could say "these branches notify here, but this branch inside that branch doesn't, and instead goes over THERE".

As for the notification, right now, the notification system checks on a specified schedule to see if anything is worth warning about, and if so it gives a message that things are either "expiring soon" or "expired". The notification also contains a link to the doomsday itself, and basically tells you to go check it out. It doesn't list the offenders in the notification at this time. That's something I'm not really sure what the right way to handle is - I don't want to blast a giant TL;DR notification, but I also don't want people to start ignoring the alerts because they just say "expiring soon" for like... 4 weeks straight, when "expiring in 4 weeks" is actually very different than "expiring in a couple hours"

@7hunderbird
Copy link

Similarly, could it be possible to group certs by path in the UI? So I can click on secret/c/ops/vault for Vault or secret/c/ops/bosh for BOSH.

@thomasmitchell
Copy link
Collaborator

@7hunderbird This is a thing I've wanted for awhile - basically the ability to specify a regex to match paths to group on that can be used for collation. Right now, I'm in the middle of the slow process of converting the Web UI to Vue so that I can iterate on features like that a bit faster. I'd appreciate it if you could open up that feature request as a separate issue.

@7hunderbird
Copy link

Created #39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants