Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Grab Engineering Blog link #92

Closed
wants to merge 1 commit into from
Closed

Add Grab Engineering Blog link #92

wants to merge 1 commit into from

Conversation

yangshun
Copy link
Contributor

Grab is one of the largest transport companies in South-east Asia, and they handle 2.3 million rides daily. Their Engineering Blog content focuses on how they handle the scale of their business and is suitable for learning system design.

Copy link
Owner

@donnemartin donnemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yangshun, thanks for the PR! Please check out #18 which discusses a similar PR. It looks like this is already in the larger engineering blogs list.

@yangshun
Copy link
Contributor Author

Ah I see, gotcha. It would be helpful to add a line to that "Company Engineering Blogs" section to explain that other Engineering Blogs should be added to https://github.com/kilimchoi/engineering-blogs instead so that you don't get PRs for adding blogs in future (:

@donnemartin
Copy link
Owner

Good point :)

I'll put it on my TODO list, or I'm happy to review a PR if anyone wants to put up a fix.

Thanks!

@yangshun
Copy link
Contributor Author

I have attempted a "fix" in #96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants