-
Notifications
You must be signed in to change notification settings - Fork 46.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ja: Fix translation in Federation section #303
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
satob
commented
Jul 10, 2019
- ":" in the second paragraph is not properly translated.
- "have" (持つ) in the second paragraph shouldn't be literally translated in this situation.
- "therefore" (その結果) in the second paragraph is missing in the translation.
- The translation of "replication" should be standardized into "レプリケーション".
- "用いる" (use) in "データベースを用いる" would be mistranslation of "result in" (〜なることで).
- The meaning of the third paragraph is translated incorrectly because "cache locality" (キャッシュの局所性) is mistranslated into "ローカルキャッシュ" (local cache).
- The meaning of the 4th paragraph is translated incorrectly because "serializing" (直列化) is missing in the translation.
- ":" in the second paragraph is not properly translated. - "have" (持つ) in the second paragraph shouldn't be literally translated in this situation. - "therefore" (その結果) in the second paragraph is missing in the translation. - The translation of "replication" should be standardized into "レプリケーション". - "用いる" (use) in "データベースを用いる" would be mistranslation of "result in" (〜なることで). - The meaning of the third paragraph is translated incorrectly because "cache locality" (キャッシュの局所性) is mistranslated into "ローカルキャッシュ" (local cache). - The meaning of the 4th paragraph is translated incorrectly because "serializing" (直列化) is missing in the translation.
satob
changed the title
JA: Fix mistranslation in Federation section
ja: Fix mistranslation in Federation section
Jul 11, 2019
instreest
reviewed
Jul 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
Original Ref:
https://github.com/donnemartin/system-design-primer/blob/master/README.md#federation
donnemartin
approved these changes
Aug 5, 2019
donnemartin
changed the title
ja: Fix mistranslation in Federation section
ja: Fix translation in Federation section
Aug 5, 2019
@satob @instreest thank you! |
godelian
added a commit
to godelian/system-design-primer
that referenced
this pull request
Oct 9, 2019
* Add license disclaimer (donnemartin#76) Clearly denote the repository license is from me, not my employer (Facebook). * Fix asynchronism link in Mint README (donnemartin#69) * Fix lowercase typo in Layer 7 load balancing title (donnemartin#74) * Fix donnemartin#79: Inaccuracy in Twitter timeline and search example (donnemartin#81) * Fix typo (donnemartin#75) * Init spot_size member in parking lot exercise (donnemartin#83) * Add prev to Node class (donnemartin#82) For managing an LRU cache, we need to use a doubly linked list for move_to_front() operation. * Fix reducer argument in pastebin exercise (donnemartin#85) * Add polish translation link (donnemartin#89) * Fix typo in denormalization section (donnemartin#95) * Add policy for adding new blogs to Company engineering blogs section (donnemartin#96) * Add Russian translation link (donnemartin#91) * Treat solution subdirectories as containing Python packages (donnemartin#99) * Add Japanese translation link (donnemartin#101) * Add traditional Chinese translation link (donnemartin#105) * Add Italian translation link (donnemartin#106) * Fix typo: considering to consider in scaling AWS solution (donnemartin#109) * Add API rate limiter design link (donnemartin#108) * Add Korean translation link (donnemartin#111) * Simplify logic for is_ace and is_face_card in deck of cards solution (donnemartin#113) * Add Persian translation link (donnemartin#115) * Correct Redis list structure in Twitter solution (donnemartin#116) * Add Japanese Translation (donnemartin#114) * Update Japanese translation link (donnemartin#118) * ja: Fix typo (donnemartin#119) * Make some minor wording/formatting changes (donnemartin#120) * add Twitter Handles 3,000 Images Per Second * Add Netflix in Company Architectures (donnemartin#122) * Add Vietnamese translation link (donnemartin#128) * Add Scaling Uber in Company Architecture (donnemartin#123) * Update master-slave section anchor (donnemartin#129) * Add Facebook Live Streams (donnemartin#125) * Update contributing guidelines - PR squash (donnemartin#135) * Update re:Invent url (donnemartin#137) * Add Traditional Chinese translation (donnemartin#133) * zh-TW: Add proper line break to links (donnemartin#139) * Add Greek translation link (donnemartin#140) * Convert all .py files to be valid Python (donnemartin#98) * zh-Hans: Fix typos (donnemartin#141) * Add Spanish translation link (donnemartin#142) * Add missing colons to class methods (donnemartin#143) * Add missing self variables to Deck of Cards solution (donnemartin#145) * Add deque import to Social Graph solution (donnemartin#147) * Change LARGE to VehicleSize.LARGE in parking lot solution (donnemartin#146) * zh-TW: Fix comment format (donnemartin#155) * Fix coding errors (donnemartin#149) * Fix dict KeyError (donnemartin#152) * Fix dict KeyError (donnemartin#153) * Adding missing self variable (donnemartin#158) * Add missing enum imports (donnemartin#157) * Change variable seller to category in Mint solution (donnemartin#159) * zh-Hans: Fix typo (donnemartin#161) * Replace broken SQL tuning links (donnemartin#163) * zh-Hans: Fix PostgreSQL typo (donnemartin#166) * Fix donnemartin#148: Add State(Enum) to social_graph_snippets.py (donnemartin#167) * ja: Swap VARCHAR and CHAR translation error (donnemartin#169) * Add Arabic translation link (donnemartin#177) * Add newlines - PEP8 style (donnemartin#173) * zh-TW: Improve translations (donnemartin#176) * Fix typo in LRU cache solution (donnemartin#182) * Fix broken links (donnemartin#180) * Add German translation link (donnemartin#188) * Add Thai translation link (donnemartin#190) * Fix broken URL (donnemartin#194) * Fix error in Twitter timeline solution (donnemartin#196) * Fix wording in call center solution (donnemartin#197) * Resolve donnemartin#195: Fix broken GitHub URLs (donnemartin#199) * zh-Hans: Fix typo: 'Twitter' (donnemartin#200) * Update Twitter/Facebook exercise description (donnemartin#202) * Fix typo in CAP theorem section (donnemartin#205) * Fix broken links (donnemartin#204) * Fix donnemartin#126: Update link to Anki decks (donnemartin#206) * Fix typo in Design Pastebin.com exercise (donnemartin#210) * zh-Hans: Fix translation (donnemartin#208) * zh-Hans: Update translation (donnemartin#212) * zh-Hans: Update translation (donnemartin#209) * Update Cassandra architecture links (donnemartin#213) * Update README intro (donnemartin#216) * Resolve donnemartin#214: Add reference links to message queues section (donnemartin#218) * Update Scalability for Dummies link (donnemartin#224) * ja: Fix typo (donnemartin#226) * zh-TW: Update index anchors (donnemartin#227) * Add Link: A 360 Degree View Of The Entire Netflix Stack (donnemartin#229) * Fix donnemartin#228: Address mutex latency discrepancy (donnemartin#233) * Add Bengali translation link (donnemartin#242) * Add missing word in cache write through discussion (donnemartin#245) * zh-Hans: Fix typo (donnemartin#246) * Fix grammar in document store section (donnemartin#247) * Fix typo in Twitter timeline and search solution (donnemartin#251) * Update document-store to document store (donnemartin#255) * Enable Python syntax highlighting in Pastebin sample code (donnemartin#257) * Fix broken SQL link in Scaling AWS exercise (donnemartin#258) Fix broken SQL link in Scaling AWS exercise * Update HDFS design link to the latest version (donnemartin#275) * Enable syntax highlighting in all python code snippets (donnemartin#268) * Translate language list (donnemartin#252) * Add Ebook generation script (donnemartin#207) * Add availability in numbers section (donnemartin#237) * Update language lists in translations (donnemartin#280) * Add Hebrew translation link (donnemartin#286) * zh-Hans: Translate Pastebin solution (donnemartin#273) * ja: Fix typo of Big-O notation in KVS section (donnemartin#292) * JA: Fix mistranslation in Horizontal scaling section - The Japanese translation is ambiguous about “vertical scaling” means scaling out or scaling up. - The word “expensive” is missing in the Japanese translation. * JA: Fix mistranslation in Reverse proxy (web server) section - Fix mistranslation of parallel structure. (not information/blacklist/limit, but hide/blacklist/limit) * ja: Fix mistranslation in "Horizontal scaling" * JA: Fix mistranslation in Weak consistency section (donnemartin#299) * JA: Fix mistranslation in Push CDNs section (donnemartin#300) * JA: Fix mistranslation in Federation section (donnemartin#303) * ja: Fix translation in "Anki flashcards" (donnemartin#306) * ja: Fix translation in “Disadvantage(s): load balancer” (donnemartin#307) * ja: Fix translation in Service Discovery section (donnemartin#308)
sleepyneko
pushed a commit
to sleepyneko/system-design-primer
that referenced
this pull request
May 31, 2020
aymns
pushed a commit
to aymns/system-design-primer
that referenced
this pull request
Sep 13, 2020
spuyet
added a commit
to spuyet/system-design-primer
that referenced
this pull request
Jul 25, 2022
* add Twitter Handles 3,000 Images Per Second * Fix grammar in document store section (donnemartin#247) * Fix typo in Twitter timeline and search solution (donnemartin#251) * Update document-store to document store (donnemartin#255) * Enable Python syntax highlighting in Pastebin sample code (donnemartin#257) * Fix broken SQL link in Scaling AWS exercise (donnemartin#258) Fix broken SQL link in Scaling AWS exercise * Update HDFS design link to the latest version (donnemartin#275) * Enable syntax highlighting in all python code snippets (donnemartin#268) * Translate language list (donnemartin#252) * Add Ebook generation script (donnemartin#207) * Add availability in numbers section (donnemartin#237) * Update language lists in translations (donnemartin#280) * Add Hebrew translation link (donnemartin#286) * zh-Hans: Translate Pastebin solution (donnemartin#273) * ja: Fix typo of Big-O notation in KVS section (donnemartin#292) * JA: Fix mistranslation in Horizontal scaling section - The Japanese translation is ambiguous about “vertical scaling” means scaling out or scaling up. - The word “expensive” is missing in the Japanese translation. * JA: Fix mistranslation in Reverse proxy (web server) section - Fix mistranslation of parallel structure. (not information/blacklist/limit, but hide/blacklist/limit) * ja: Fix mistranslation in "Horizontal scaling" * JA: Fix mistranslation in Weak consistency section (donnemartin#299) * JA: Fix mistranslation in Push CDNs section (donnemartin#300) * JA: Fix mistranslation in Federation section (donnemartin#303) * ja: Fix translation in "Anki flashcards" (donnemartin#306) * ja: Fix translation in “Disadvantage(s): load balancer” (donnemartin#307) * ja: Fix translation in Service Discovery section (donnemartin#308) * Add API security checklist (donnemartin#328) * zh-Hans: Change translation in SQL tuning (donnemartin#318) * ja: Fix mistranslation in SQL tuning section (donnemartin#305) * Change raise NotImplemented to raise NotImplementedError (donnemartin#345) * Fix broken round robin links (donnemartin#351) * Fix broken CAP theorem link (donnemartin#355) * Fix broken link in CAP theorem section (donnemartin#348) * zh-cn: Sync with upstream to keep it up-to-date (donnemartin#374) * Revert "zh-cn: Sync with upstream to keep it up-to-date (donnemartin#374)" (donnemartin#391) This reverts commit 301b9d8. donnemartin#374 overwrote the English version of the solutions * zh-Hans: Translate solutions (donnemartin#392) * Update "Scaling up to your first 10 million users" link (donnemartin#411) * Add missing comma in Mint solution (donnemartin#399) * Fix single point of failure typo (donnemartin#398) * Fix layer 7 load balancers typo (donnemartin#317) * Update contributing guidelines for translations (donnemartin#434) * Add pull request template (donnemartin#435) * Add status of translations (donnemartin#436) * Highlight translation request (donnemartin#437) * Resolve donnemartin#164 - Fix phrasing with availability and partition tolerance (donnemartin#350) * Check dependencies in Ebook gen script (donnemartin#406) * Fix typo: Change replication to federation (donnemartin#418) * Update Twitter back-of-the-envelope calculations (donnemartin#414) * Fix typos in Twitter and web crawler exercises (donnemartin#438) * Fix donnemartin#313: Clarify availability patterns (donnemartin#439) * Add system design template link (donnemartin#433) * kr: Fix Korean translation link in language index (donnemartin#340) * Fix Mint exercise bugs and typos (donnemartin#409) * Remove redundant SQL index in Pastebin exercise (donnemartin#405) * Additional question, build an exchange fixes donnemartin#281 * Add CAP theorem video link (donnemartin#400) * Fix loop bug in deck of cards exercise (donnemartin#396) * Update dead links (donnemartin#321) * Add links for latency based and geolocation based routing (donnemartin#319) * Clarify CDN advantages (donnemartin#310) * Change disk to HDD for clarity (donnemartin#295) * Update README.md * Remove extraneous __init__.py (donnemartin#393) * Remove Imgur dependency by storing images locally (donnemartin#168) * Fix donnemartin#335: Update OSI image to Open Systems Interconnection (donnemartin#447) * Fix translations link in PR template (donnemartin#451) * Update broken HBase architecture link (donnemartin#481) * Fix Celery URL (donnemartin#486) * Fixing the indieflashblog address with archive.org since website has been discontinued * Fix LRU cache link (donnemartin#505) * Fix capitalization of Dropbox (donnemartin#511) * Update GitHub Engineering Blog link * Fix memcache architecture URL (donnemartin#631) * Fix # 650: Replace broken weighted round robin link (donnemartin#651) * Fix typos (donnemartin#661) Co-authored-by: fluency03 <fluency.03@gmail.com> Co-authored-by: Chang Liu <fluency03@users.noreply.github.com> Co-authored-by: glusa8 <glusa8@berkeley.edu> Co-authored-by: yiksanchan <evan.chanyiksan@gmail.com> Co-authored-by: Manas Karekar <manaskarekar@users.noreply.github.com> Co-authored-by: Sean Han <hanxiaobow@gmail.com> Co-authored-by: Donne Martin <donne.martin@gmail.com> Co-authored-by: leontyr <leontyr@gmail.com> Co-authored-by: Simon Knott <simoknott@gmail.com> Co-authored-by: minhaz <minhazav@gmail.com> Co-authored-by: Kevin Xu <kevin.xu.v@gmail.com> Co-authored-by: Yuya Ma'emichi <6386129+Wintus@users.noreply.github.com> Co-authored-by: SATO Yusuke <yusuke.sato.zz@gmail.com> Co-authored-by: Duy Nguyen Hoang <nhduy88@gmail.com> Co-authored-by: Brandon <brandonJY@users.noreply.github.com> Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Dan Choi <ygdanchoi@gmail.com> Co-authored-by: vyq <qvc246+github@gmail.com> Co-authored-by: Danny Jung <3496334+dannyjung90@users.noreply.github.com> Co-authored-by: 根号三 <imsqrtthree@gmail.com> Co-authored-by: userstartupideas <64709217+userstartupideas@users.noreply.github.com> Co-authored-by: Alexander Teno <5354921+alexanderteno@users.noreply.github.com> Co-authored-by: panguncle <54489480+panguncle@users.noreply.github.com> Co-authored-by: shiyujiucsb <16054786+shiyujiucsb@users.noreply.github.com> Co-authored-by: Neesara <neethums333@gmail.com> Co-authored-by: Sainadh Devireddy <sainadh976@gmail.com> Co-authored-by: Kevin Liu <kevinliu23@gmail.com> Co-authored-by: Kofi Forson <kofif7kofi@gmail.com> Co-authored-by: Agade09 <n.sillitoe@gmail.com> Co-authored-by: Nachiket Acharya <nachiket.acharya@microsoft.com> Co-authored-by: Rahil <rahilrshk@gmail.com> Co-authored-by: Youngchul Bang <youngchul@gmail.com> Co-authored-by: Vladimir Mikhaylov <38596482+vemikhaylov@users.noreply.github.com> Co-authored-by: John Richardson <42470533+John-Richardson@users.noreply.github.com> Co-authored-by: Harry Moreno <morenoh149@gmail.com> Co-authored-by: Manas Gupta <guptamanas1998@gmail.com> Co-authored-by: Joilson Cisne <joilsoncisne@gmail.com> Co-authored-by: Ganessh Kumar <rpganesshkumar@gmail.com> Co-authored-by: Varsha Muzumdar <varsha.vjm@gmail.com> Co-authored-by: Noe Brito <n.o.brito@hotmail.com> Co-authored-by: Adam Dobrawy <ad-m@users.noreply.github.com> Co-authored-by: Daniel Julius Lasiman <dj.lasiman@gmail.com> Co-authored-by: Isetty Ravi Teja Kumar <iravitejakumar@gmail.com> Co-authored-by: Ryo Shibayama <j02521@gmail.com> Co-authored-by: Peter Yao <peteryao7@gmail.com> Co-authored-by: Abdalla Mohamed <sharpcodex@gmail.com> Co-authored-by: Laurent Erignoux <lerignoux@gmail.com> Co-authored-by: Trần Tiến Đức <trantienduchn@gmail.com> Co-authored-by: ayyjohn <alecjohnson55@gmail.com> Co-authored-by: Lawrence Chou <lawrencechou1024@gmail.com> Co-authored-by: Nnachevvv <44066540+Nnachevvv@users.noreply.github.com> Co-authored-by: mleers <mleers4@gmail.com> Co-authored-by: Kian-Meng Ang <kianmeng.ang@gmail.com>
Godfrey-Ndungu
pushed a commit
to Godfrey-Ndungu/system-design-primer
that referenced
this pull request
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.