Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Codecov ignore settings for external libraries #1

Closed
donnemartin opened this issue May 9, 2016 · 2 comments
Closed

Fix Codecov ignore settings for external libraries #1

donnemartin opened this issue May 9, 2016 · 2 comments

Comments

@donnemartin
Copy link
Owner

donnemartin commented May 9, 2016

Running coverage locally results in a 93% coverage rate.

Name                                                               Stmts   Miss  Cover
--------------------------------------------------------------------------------------
.tox/py35/lib/python3.5/site-packages/gitsome/__init__.py              1      0   100%
.tox/py35/lib/python3.5/site-packages/gitsome/completer.py            73      4    95%
.tox/py35/lib/python3.5/site-packages/gitsome/completions.py          12      0   100%
.tox/py35/lib/python3.5/site-packages/gitsome/completions_git.py       2      0   100%
.tox/py35/lib/python3.5/site-packages/gitsome/config.py              254     30    88%
.tox/py35/lib/python3.5/site-packages/gitsome/formatter.py           218      4    98%
.tox/py35/lib/python3.5/site-packages/gitsome/github.py              285     26    91%
.tox/py35/lib/python3.5/site-packages/gitsome/githubcli.py           158      0   100%
.tox/py35/lib/python3.5/site-packages/gitsome/rss_feed.py              1      0   100%
.tox/py35/lib/python3.5/site-packages/gitsome/table.py                69      7    90%
.tox/py35/lib/python3.5/site-packages/gitsome/utils.py                63      6    90%
.tox/py35/lib/python3.5/site-packages/gitsome/view_entry.py           16      2    88%
.tox/py35/lib/python3.5/site-packages/gitsome/web_viewer.py           72      3    96%
--------------------------------------------------------------------------------------
TOTAL                                                               1224     82    93%

Codecov is showing 51% coverage since it isn't properly excluding external libraries in the gitsome/lib folder.

The ignores in codecov.yml don't seem to be working.

Docs reference.

@donnemartin
Copy link
Owner Author

Fixed with:

@coracobra
Copy link

hello world

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants