Skip to content

Commit b8eebdb

Browse files
committed
Adding some more instructions to UPDATING_PYPI.md
1 parent 4f0ddec commit b8eebdb

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

UPDATING_PYPI.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,15 @@ You will also need a pypi account and access to the package. Domo IT/Ops can pro
1818
1. Increment the version inside `setup.py`
1919
1. Double-check this version matches what's already in Pypi
2020
2. Run `python3 -m build` from the `domo-python-sdk` directory
21-
1. This should create a directory called dist and add two files: `pydomo-{version}-py3-none-any.whl` and `pydomo-{version}.tar.gz`.
21+
1. This should create a directory called `dist` and add two files: `pydomo-{version}-py3-none-any.whl` and `pydomo-{version}.tar.gz`.
2222
3. Run `python3 -m twine upload --repository pypi dist/*`
2323
1. This will ask for your API key. Paste it in.
2424
2. You should see that your new version was uploaded successfully.
2525
4. Check Pypi to verify your version was uploaded correctly.
2626
5. Update `CHANGELOG.md` to include your latest changes.
27+
6. Delete the `dist` directory (`rm -rf dist`)
28+
1. First, the `dist` directory is ignored in git (see `.gitignore`). It does not need to be saved once it's uploaded.
29+
2. Second, re-running the `build` command does not remove existing files from `dist`, it only adds new ones. So if you haven't deleted the `dist` directory, and you upgrade the version and `build` again, the `dist` directory will hold both the old version and the new version. When running `twine upload` you don't want to have both versions in `dist`, hence why you should delete it now.
2730

2831
## Sources/More Information
2932

0 commit comments

Comments
 (0)