Skip to content

Commit 268920c

Browse files
divbzerodomdfcoding
authored andcommitted
Update maildev ports {80 => 1080} and {25 => 1025} (pypi#11141)
maildev, the mock email service used for development, wasn't working: 1. The `warehouse.email.send_email` task hit `ConnectionRefusedError`. 2. The maildev interface http://localhost:1080/ wouldn't load. Turns out that maildev ports were updated with v1.1.1. Updating ports according to maildev/maildev#281 resolved both issues, and pinning the version to v2.0.2 will prevent unexpected changes in the future.
1 parent 6cd537d commit 268920c

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

dev/environment

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ SIMPLE_BACKEND=warehouse.packaging.services.LocalSimpleStorage path=/var/opt/war
2626
DOCS_BACKEND=warehouse.packaging.services.LocalDocsStorage path=/var/opt/warehouse/docs/
2727
SPONSORLOGOS_BACKEND=warehouse.admin.services.LocalSponsorLogoStorage path=/var/opt/warehouse/sponsorlogos/
2828

29-
MAIL_BACKEND=warehouse.email.services.ConsoleAndSMTPEmailSender host=maildev port=25 ssl=false sender=noreply@pypi.org
29+
MAIL_BACKEND=warehouse.email.services.ConsoleAndSMTPEmailSender host=maildev port=1025 ssl=false sender=noreply@pypi.org
3030

3131
BREACHED_PASSWORDS=warehouse.accounts.NullPasswordBreachedService
3232

docker-compose.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,9 +134,10 @@ services:
134134
- ./bin:/opt/warehouse/src/bin:z
135135

136136
maildev:
137-
image: maildev/maildev
137+
image: maildev/maildev:2.0.2
138138
ports:
139-
- "1080:80"
139+
- "1080:1080"
140+
- "1025:1025"
140141

141142
notdatadog:
142143
build:

0 commit comments

Comments
 (0)