Merge pull request #1882 from dolthub/taylor/clone-admin-global

Add dynamic privilege CLONE_ADMIN

Author: tbantle22

enginetest/queries/priv_auth_queries.go

@@ -596,6 +596,7 @@ var UserPrivTests = []UserPrivilegeTest{
 		SetUpScript: []string{
 			"CREATE USER testuser@localhost;",
 			"GRANT REPLICATION_SLAVE_ADMIN ON *.* TO testuser@localhost;",
+			"GRANT CLONE_ADMIN ON *.* TO testuser@localhost;",
 		},
 		Assertions: []UserPrivilegeTestAssertion{
 			{
@@ -611,7 +612,7 @@ var UserPrivTests = []UserPrivilegeTest{
 				Query: "SHOW GRANTS FOR testuser@localhost;",
 				Expected: []sql.Row{
 					{"GRANT USAGE ON *.* TO `testuser`@`localhost`"},
-					{"GRANT REPLICATION_SLAVE_ADMIN ON *.* TO `testuser`@`localhost`"},
+					{"GRANT CLONE_ADMIN, REPLICATION_SLAVE_ADMIN ON *.* TO `testuser`@`localhost`"},
 				},
 			},
 			{

sql/plan/clone_commands.go

@@ -0,0 +1,19 @@
+// Copyright 2022 Dolthub, Inc.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package plan
+
+// DynamicPrivilege_CloneAdmin is the dynamic privilege required to execute clone commands.
+// https://dev.mysql.com/doc/refman/8.0/en/privileges-provided.html#priv_clone-admin
+const DynamicPrivilege_CloneAdmin = "clone_admin"

sql/plan/grant_data.go

@@ -217,7 +217,7 @@ func (p *Privilege) String() string {
 func (p *Privilege) IsValidDynamic() bool {
 	if p.Type == PrivilegeType_Dynamic {
 		switch p.Dynamic {
-		case DynamicPrivilege_ReplicationSlaveAdmin:
+		case DynamicPrivilege_ReplicationSlaveAdmin, DynamicPrivilege_CloneAdmin:
 			return true
 		}
 	}