Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree widget #1516

Merged
merged 72 commits into from
Sep 25, 2020
Merged

Tree widget #1516

merged 72 commits into from
Sep 25, 2020

Conversation

samends
Copy link
Contributor

@samends samends commented Jul 21, 2020

Type: Feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit tests are included in the PR
  • For new widgets, an entry has been added to the .dojorc
  • For new widgets, theme.variant() is added to the root domnode
  • Any widget variant uses theme.compose like this
  • WidgetProperties are exported

Adds tree widget to widget project

Resolves #1214

@vercel
Copy link

vercel bot commented Jul 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojowidgets/53wg9wgyx
✅ Preview: https://dojowidgets-git-fork-samends-treewidget.dojo1.vercel.app

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/esago0iu0
✅ Preview: https://widget-test-docs-git-fork-samends-treewidget.dojo1.vercel.app

@vercel vercel bot had a problem deploying to Preview – dojo.widgets August 14, 2020 19:08 Failure
@vercel vercel bot had a problem deploying to Preview – widget-test-docs August 14, 2020 19:08 Error
@samends samends mentioned this pull request Aug 18, 2020
7 tasks
@vercel vercel bot had a problem deploying to Preview – dojo.widgets August 18, 2020 21:23 Failure
@vercel vercel bot temporarily deployed to Preview – widget-test-docs August 18, 2020 21:23 Inactive
@vercel vercel bot temporarily deployed to Preview – dojo.widgets August 18, 2020 21:43 Inactive
@vercel vercel bot temporarily deployed to Preview – widget-test-docs August 18, 2020 21:44 Inactive
@vercel vercel bot had a problem deploying to Preview – widget-test-docs August 18, 2020 21:46 Error
Copy link
Member

@tomdye tomdye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this tree widget may also benefit from many aria properties.
https://www.w3.org/WAI/GL/wiki/Using_ARIA_trees gives some useful guidance on the topic.

src/theme/default/tree.m.css Show resolved Hide resolved
src/tree/index.tsx Outdated Show resolved Hide resolved
src/tree/index.tsx Outdated Show resolved Hide resolved
src/tree/index.tsx Outdated Show resolved Hide resolved
src/tree/index.tsx Show resolved Hide resolved
src/tree/index.tsx Show resolved Hide resolved
src/tree/index.tsx Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #1516 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1516      +/-   ##
==========================================
- Coverage   91.10%   91.05%   -0.06%     
==========================================
  Files          89       92       +3     
  Lines        4398     4628     +230     
  Branches     1186     1247      +61     
==========================================
+ Hits         4007     4214     +207     
- Misses        192      197       +5     
- Partials      199      217      +18     
Impacted Files Coverage Δ
src/tree/index.tsx 92.59% <ø> (ø)
src/tree/tests/unit/TreeData.mock.ts 100.00% <ø> (ø)
src/rate/index.tsx 83.58% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a6792d...731057d. Read the comment docs.

@vercel vercel bot had a problem deploying to Preview – widget-test-docs September 24, 2020 13:51 Failure
@vercel vercel bot had a problem deploying to Preview – dojo.widgets September 24, 2020 13:51 Failure
@samends samends merged commit 815ad26 into dojo:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree widget
4 participants