Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions (groups of buttons/icons) inconsistency #1574

Open
matt-gadd opened this issue Nov 20, 2020 · 0 comments
Open

Actions (groups of buttons/icons) inconsistency #1574

matt-gadd opened this issue Nov 20, 2020 · 0 comments
Assignees
Labels

Comments

@matt-gadd
Copy link
Contributor

Bug

A number of widgets have the concept of "Actions", they are mostly collections of buttons/icons. It would be nice if we had one consistent pattern for these. For example at the moment in SpeedDial there is a specific Action component:

<SpeedDial>
  <Action
    onClick={() => {
      icache.set('action', 'Mailing');
    }}
  >
    <Icon type="mailIcon" />
  </Action>
</SpeedDial>

yet for the Header actions are defined like so:

<Header>
  {{
    title: 'My App',
    actions: [
      <Link to="#foo">Foo</Link>,
      <Link to="#bar">Bar</Link>,
      <Link to="#baz">Baz</Link>
    ]
  }}
</Header>
@matt-gadd matt-gadd added the bug label Nov 20, 2020
@tomdye tomdye added medium Medium size issue medium priority labels Mar 22, 2021
@KaneFreeman KaneFreeman self-assigned this Mar 30, 2021
@cheriebrown cheriebrown assigned agubler and matt-gadd and unassigned KaneFreeman Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants