Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dialog] rename role enum to be roleType #106

Closed
rishson opened this issue Apr 11, 2017 · 0 comments
Closed

[dialog] rename role enum to be roleType #106

rishson opened this issue Apr 11, 2017 · 0 comments
Labels
breaking-change
Milestone
2017.04

Comments

@rishson
Copy link
Contributor

rishson commented Apr 11, 2017

All other enums in widgets have the suffix Type, e.g. ButtonType.
We should bring role into line.
@rishson rishson changed the title Rename role in Dialog to be roleType [dialog] rename role enum to be roleType Apr 11, 2017
@rishson rishson mentioned this issue Apr 11, 2017
Closed
@dylans dylans added this to the 2017.04 milestone Apr 11, 2017
@bitpshr bitpshr mentioned this issue Apr 12, 2017
Merged
3 tasks
@bitpshr bitpshr mentioned this issue Apr 19, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
2017.04
Development

No branches or pull requests
2 participants
@dylans @rishson