Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support special head tag for rendering node in the document head #805

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

agubler
Copy link
Member

@agubler agubler commented Jun 12, 2020

Type: feature

The following has been addressed in the PR:

Description:

Adds built in support for adding nodes to the document head controlled by the rendering engine. The support is a mirror of the support for adding nodes to the document body.

Resolves #804

@agubler agubler added enhancement New feature or request needs back-port The fix requires back porting to one or more previous major versions area: core Core labels Jun 12, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit aa70ee8:

Sandbox Source
pedantic-http-n2w80 Configuration

@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #805 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #805   +/-   ##
=======================================
  Coverage   97.52%   97.52%           
=======================================
  Files         126      126           
  Lines        7927     7933    +6     
  Branches     1824     1826    +2     
=======================================
+ Hits         7731     7737    +6     
  Misses        196      196           
Impacted Files Coverage Δ
src/core/vdom.ts 97.98% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c70b240...aa70ee8. Read the comment docs.

@agubler agubler merged commit e5aa994 into dojo:master Jun 15, 2020
agubler added a commit to agubler/framework that referenced this pull request Jun 15, 2020
agubler added a commit that referenced this pull request Jun 15, 2020
…ent head (#805) (#806)

* support special head tag for rendering node in the document head (#805)

* run ci for backports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: core Core enhancement New feature or request needs back-port The fix requires back porting to one or more previous major versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow tags such as meta to be added to the document head
3 participants