Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node replacement utility #440

Closed
wants to merge 4 commits into from
Closed

Conversation

maier49
Copy link
Contributor

@maier49 maier49 commented Jul 8, 2019

Type: feature

The following has been addressed in the PR:

Description:
Provides a replace utility that functions similarly to decorate but instead replaces the node with the returned value.
Resolves #410

@maier49 maier49 requested review from agubler and matt-gadd July 8, 2019 17:33
@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #440 into master will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
- Coverage   97.48%   97.42%   -0.07%     
==========================================
  Files         108      113       +5     
  Lines        6047     6410     +363     
  Branches     1353     1457     +104     
==========================================
+ Hits         5895     6245     +350     
- Misses        152      165      +13     
Impacted Files Coverage Δ
src/core/util.ts 99.24% <100.00%> (+0.24%) ⬆️
src/routing/Outlet.ts 71.42% <0.00%> (-28.58%) ⬇️
src/core/animations/cssTransitions.ts 0.00% <0.00%> (-6.67%) ⬇️
src/routing/Link.ts 94.73% <0.00%> (-5.27%) ⬇️
src/testing/harness.ts 97.14% <0.00%> (-0.12%) ⬇️
src/shim/array.ts 100.00% <0.00%> (ø)
src/core/WidgetBase.ts 100.00% <0.00%> (ø)
src/core/NodeHandler.ts 100.00% <0.00%> (ø)
src/routing/ActiveLink.ts 100.00% <0.00%> (ø)
src/testing/mocks/middleware/intersection.ts 100.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 394b1c6...5344566. Read the comment docs.

@maier49 maier49 closed this Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant