Allow returning a node from decorate modifier to replace a node #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maier49
force-pushed
the
298-decorate-replace-node
branch
from
25ce851
to
d31b91f
Compare
matt-gadd
requested changes
Jul 8, 2019
| import { isWNode, isVNode } from './vdom'; | ||
|
|
||
| const slice = Array.prototype.slice; | ||
| const hasOwnProperty = Object.prototype.hasOwnProperty; | ||
|
|
||
| export interface Modifier<T extends DNode> { | ||
| (dNode: T, breaker: () => void): void; | ||
| (dNode: T, breaker: () => void): void | VNode | WNode | null | string | boolean; |
There was a problem hiding this comment.
should this not just be void | DNode?
There was a problem hiding this comment.
The reason I didn't do that was because it's checking if it's a new node based on whether the return is strictly equal to undefined. DNode includes undefined so if they returned undefined as a new node it wouldn't be picked up.
If that's a problem I could add another callback to pass the new node to instead or something to avoid the ambiguity?
There was a problem hiding this comment.
Hmmm, it seems like we'd want to support being able to return undefined right?
|
After some more discussion, this functionality is going to be implemented as a separate function rather than being added to the current decorate functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Modifies
decorateso that returning a node or value from the modifier function will replace it in the tree. It excludesundefinedfrom the type so we can identify if something was actually returned.Resolves #298