Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command exits when using watch or serve #407

Closed
tomdye opened this issue Jun 22, 2020 · 1 comment · Fixed by #408
Closed

Command exits when using watch or serve #407

tomdye opened this issue Jun 22, 2020 · 1 comment · Fixed by #408

Comments

@tomdye
Copy link
Member

tomdye commented Jun 22, 2020

Bug

Package Version: 7.0.1

Expected behavior:

When using watch or serve, the command should continue to run after the first build

Actual behavior:

The command exits after the first build has completed

@tomdye
Copy link
Member Author

tomdye commented Jun 22, 2020

Notes from initial discovery:

since we added the process.exit(0) on cli, the cli-build-app command resolves the command promise wrongly when it runs watch or serve. This causes the command to exit without serving or watching. If you remove the resolve() calls from serve it's all good, BUT, plot twist, the watch command needs to resolve for the serve, but not for the main watch command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant