We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement
The serve option is not intended to be used to serve applications in production. We should add a warning message when running serve for the user.
serve
The text was updated successfully, but these errors were encountered:
Right now serve fails when not run in a one of the test modes.
Are you thinking of something like this for a warning?
devpaul@6443e0a
It'll warn if NODE_ENV === 'production' or if they (somehow) run serve when not in a test mode,
NODE_ENV === 'production'
Sorry, something went wrong.
@devpaul no, the serve option should just consistently warn saying that it's not a production server (regardless of mode). preferably here: https://github.com/dojo/cli-build-app/blob/master/src/main.ts#L81, which uses the logger.
--serve
devpaul
Successfully merging a pull request may close this issue.
Enhancement
The
serve
option is not intended to be used to serve applications in production. We should add a warning message when runningserve
for the user.The text was updated successfully, but these errors were encountered: