Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print production warning when using serve #296

Closed
agubler opened this issue Jul 10, 2019 · 2 comments · Fixed by #376
Closed

Print production warning when using serve #296

agubler opened this issue Jul 10, 2019 · 2 comments · Fixed by #376
Assignees
Labels
enhancement next Issue/Pull Request for the next major version

Comments

@agubler
Copy link
Member

agubler commented Jul 10, 2019

Enhancement

The serve option is not intended to be used to serve applications in production. We should add a warning message when running serve for the user.

@agubler agubler added enhancement next Issue/Pull Request for the next major version labels Sep 18, 2019
@devpaul devpaul self-assigned this Feb 4, 2020
@devpaul
Copy link
Member

devpaul commented Feb 4, 2020

Right now serve fails when not run in a one of the test modes.

Are you thinking of something like this for a warning?

devpaul@6443e0a

It'll warn if NODE_ENV === 'production' or if they (somehow) run serve when not in a test mode,

@matt-gadd
Copy link
Contributor

@devpaul no, the serve option should just consistently warn saying that it's not a production server (regardless of mode). preferably here: https://github.com/dojo/cli-build-app/blob/master/src/main.ts#L81, which uses the logger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement next Issue/Pull Request for the next major version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants