Fixes #25 #26
Merged
Fixes #25 #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jkamleh
commented
Apr 15, 2021
jkamleh
commented
- Fixes Minor refactoring suggestion #25
- Rename class in SigningViaEmail.cs from SingingViaEmail -> SigningViaEmail + update usage reference
- Fixes docusign#25 - Rename class in SigningViaEmail.cs from SingingViaEmail -> SigningViaEmail + update usage reference
|
Thank you @jkamleh for catching this and caring and submitting a PR. We appreciate it! |
InbarGazit
approved these changes
Apr 15, 2021
|
@jkamleh I noticed you fixed the |
|
Thanks @InbarGazit. I did notice that but was unsure if it was going to be used in the near future, I've opened a new PR to remove unused |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.