Add option for using RETURNING clause for fetching entity ID #12177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brajk19
commented
Sep 24, 2025
Comment on lines
+1474
to
+1481
| /** | ||
| * This should be replaced with a method call from AbstractPlatform | ||
| */ | ||
| private function supportsReturningClause(AbstractPlatform $platform): bool | ||
| { | ||
| return $platform instanceof PostgreSQLPlatform | ||
| || $platform instanceof MariaDb1052Platform // lowest version 10.5.0 (https://mariadb.com/kb/en/insertreturning/) | ||
| || $platform instanceof SqlitePlatform; // lowest version 3.35.0 (https://www.sqlite.org/lang_returning.html) |
There was a problem hiding this comment.
separate PR in dbal should be opened for this if this gets accepted
Brajk19
commented
Sep 24, 2025
| */ | ||
| public function exists(object $entity, Criteria|null $extraConditions = null): bool; | ||
|
|
||
| public function usesReturningClause(): bool; |
There was a problem hiding this comment.
i had to add this to interface because JoinedSubclassPersister::executeInserts invokes root persister
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes enable usage of RETURNING clause for getting entity id instead of relying on another query to db.
Few conditions have to be met:
If conditions are met, returning clause is added to the end of insert query.